<< adding Thejaswini to this loop, as I guess she is stil not part of
this alias >>
On 12/ 2/11 11:30 AM, Brock Pytlik wrote:
On 12/01/11 13:32, Shawn Walker wrote:
On 12/01/11 04:11, Saurabh Vyas wrote:
<< initiating this review on behalf of Thejaswini >>
Hi All,
Please review these trivial fixes and let me know your comments.
18958 Error message concerning /var/pkg/lock & lack of privileges could
be improved
7095081 installupdate.py has typo: 'futher' instead of 'further'
webrev :
https://cr.opensolaris.org/action/browse/pkg/saurabhv/18958/webrev/
I don't think the changes in src/modules/client/api_errors.py will
really "fix" things.
In fairness, isn't /var/pkg/lock the common manifestation of this error
message? I agree that our own custom output routines would be
preferable, but we've also been saying we should have those for quite a
while, so it doesn't seem to be a priority. It seems to me that this
improves the common case. The easy to implement alternative I would be
fine with would be to just wrap the line after the path is printed.
So if this fix address problem in general (thought we still might have
issues in specific case), would be ok to proceed with this ?
Or should I suggest Thejaswini to modify the fix (to address this issue
completely ?)
Thanks in advance,
~Saurabh
Brock
The original \n was placed there to ensure the message wrapped in most
cases.
While moving the \n as you have improves this specific case, it may
make others worse. Recall that any pathname could be placed there, and
some are very long.
We should just remove the \n's from these messages and then enforce
wrapping using our own custom output routines at runtime. But that's
not a simple change.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems |Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
