Alan Coopersmith wrote: > On 12/06/11 05:53, Petr Cvachoucek wrote: > >Hi all, > >I'd like to ask for a code review for this CR. > > > >7109218 pkg uninstall application/texinfo-update leads to service going into > >maintenance > >http://monaco.us.oracle.com/detail.jsf?cr=7109218 > > > >Webrev: > >http://tbd.cz.oracle.com/~pcvachou/webrevs/7109218-userland-texinfo/ > > > >It is just a single-line change in the package manifest file. > > While the change seems reasonable, it also seems like we shouldn't have to > manually tag every SMF manifest with a disable_fmri for itself.
It's not the manifest getting tagged with disable_fmri, but the service method. What's happening is that because the package delivers a) the service (including the manifest and its method script) and b) files tagged with restart_fmri=<the service it delivers>, then when the package is removed, one of the fmris that gets restarted is the service that just got removed, and because the method is now missing, it can't do anything. I suppose another possible failure method here is that manifest-import gets restarted before the texinfo service, and then when we restart texinfo, we get a complaint about no such service. Given that we do know what services are being delivered by a package, we could do some work to see that a service is disappearing, and take it off the restart and refresh lists, and prevent it from being restarted when it's on the suspend list. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
