On 12/09/11 12:08, Shawn Walker wrote:
On 12/08/11 13:58, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/19098-v1
Bugs:
19098 allow_action can be faster for both variant and facet
19100 imageplan uses apx as a module but doesn't import as module as apx
src/modules/facet.py:
need copyright update
lines 134-136: did you check and see if f.startswith("facet.") was
faster/slower than f[:6]? In many cases, startswith is faster because
slicing requires the creation of a temporary object and additional
memory allocation.
I did. On x86. startswith is about 2x slower than using a slice. On
sparc I couldn't find a noticeable difference. In fact, my theory is
that this is where most of the speedup is coming from
src/modules/variant.py:
lines 83, 93: same as above in regards to startswith
Otherwise, very cool.
Thanks :)
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
