On 12/21/11 23:04, Shawn Walker wrote:
On 12/21/11 02:13, Saurabh Vyas wrote:
Hi All,
Please review the fix for
18958 - Error message concerning /var/pkg/lock & lack of privileges
could be improved
7123469 error handling in __api_plan_exception can be improved
webrev : https://cr.opensolaris.org/action/browse/pkg/saurabhv/18958/
For this fix, I have created a new exception class & used a simplified
error msg (rather than ' Could not operate on /var/pkg/lock' which is
moreover an implementation detail).
This also needed bumping up the PKG_CLIENT_VERSION (to 71, as suggested
by Shawn)
Please let me know your thoughts / comments.
BTW I ran the test suite & I got 2 errors (which I got on the baseline
too)
======================================================================
BASELINE MISMATCH: The following results didn't match the baseline.
----------------------------------------------------------------------
cli.t_pkg_sysrepo.py TestSysrepo.test_11_https_repos: error
cli.t_https.py TestHTTPS.test_01_basics: error
----------------------------------------------------------------------
I ran the test suite on my own system last night and didn't see a failure.
If you could provide the error output of the failures, we can then
determine the cause of them and eliminate any potential issues.
Hi Shawn,
Here is the error o/p that I got with failing tests.....
======================================================================
ERROR: cli.t_pkg_sysrepo.py TestSysrepo.test_11_https_repos
----------------------------------------------------------------------
Traceback (most recent call last):
File "./pkg5unittest.py", line 545, in run
testMethod()
File "./api/../cli/t_pkg_sysrepo.py", line 1259, in test_11_https_repos
self.__prep_configuration(["https-access", "none"])
File "./api/../cli/t_pkg_sysrepo.py", line 305, in __prep_configuration
ac = self.__start_https(pc)
File "./api/../cli/t_pkg_sysrepo.py", line 281, in __start_https
ac.start()
File "./pkg5unittest.py", line 3365, in start
"starting (exit code %d)" % rc)
SysrepoStateException: Sysrepo exited unexpectedly while starting (exit
code 1)
======================================================================
ERROR: cli.t_https.py TestHTTPS.test_01_basics
----------------------------------------------------------------------
Traceback (most recent call last):
File "./pkg5unittest.py", line 545, in run
testMethod()
File "./api/../cli/t_https.py", line 170, in test_01_basics
self.ac.start()
File "./pkg5unittest.py", line 3365, in start
"starting (exit code %d)" % rc)
SysrepoStateException: Sysrepo exited unexpectedly while starting (exit
code 1)
Please let me know how can I eliminate these errors.
Thanks,
~Saurabh
-Shawn
--
Saurabh Vyas
Solaris Install Group,
Revenue Product Engineering (RPE), Systems
ORACLE India | Off Langford Road | Bangalore | 560025
|Bangalore |
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to
developing practices and products that help protect the environment
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
