On 12/30/11 13:19, Shawn Walker wrote:
On 12/29/11 19:45, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/performance
Bugs:
19104 CliTestCase.pkgsend needs to display traceback when pkgsend
tracesback
19113 old dictionary in imageplan.__find_all_conflicts should be seeded
using old_excludes
19119 generic.get_varcet_keys shouldn't use startswith
19120 Image shouldn't load the action dictionary twice during an update
19121 if actions.offsets includes number of lines with the same key,
things can be faster
19122 pkgplans should hold onto their manifests a bit longer
19123 maintaining a cache of created fmris while checking for
conflicting actions makes things faster
19124 conflicting actions should use sets of strings instead of PkgFmris
19125 pkg_solver should stop creating the same pfmris over and over
19126 manifests should track what's been excluded from them
19127 compiling re's in facets is faster than using fnmatch
I see that you provided lots of numbers for differences in update, but
did you check install for solaris-small-server and the like?
src/modules/client/image.py:
============================
lines 2454-2455: I'm uncertain about this change though those
concerns may be for reasons that are no longer valid. I would swear
this was discussed before and it was discovered that this
intentionally didn't take facets into account. That may have been
before we changed imageplanning to do conflict checking though and the
like.
At the very least, the all_variants variable is now misnamed and
needs to be changed. Perhaps 'use_excludes' instead?
I've changed this in most places the exception being the api module.
Creating an incompatible api version change for this isn't reasonable.
lines 3383-3390: I think this docstring may need an update because
of the changes made here.
line 3513-3514: It seems like this needs a stat check on the offsets
file at a minimum to ensure the data is still valid, so you need to
stash the file timestamp as well. My concern is for long-lived
clients like the packagemanager/updatemanager.
Since the file includes a timestamp, I'll use that rather than
externally stating the file.
line 3554: I'm concerned that this change may significantly increase
memory usage for long-lived clients such as the packagemanager and
updatemanager.
[snip]
Brock
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
