On 02/07/12 13:09, Danek Duvall wrote:
Brock Pytlik wrote:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7136706-v2
image.py:
- line 26: why not in alphabetical order with the rest of the imports?
oops, b/c that's a debugging import which should be removed (which is
why I always put it out away from imports I expect to be in the final
putback).
- line 3505: I don't understand why you're getting rid of the
KeyboardInterrupt handling? You don't have to return actdict if the
unlinks fail and we got here for other reasons, but I think if we hit a
^C at this point, we actually want it to take effect.
I got rid of the special handling because now we always reraise the
original exception. I couldn't see any reason to have
if isinstance(e, KeyboardInterrupt):
raise
raise
I made that change because I couldn't find a way for the actdict to be
useful without the associated stripped actions file (and also because
the code as it was written could've returned a partially filled actdict
and the consumer would never know it wasn't the entire thing).
Hth,
Brock
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
