On 02/27/12 15:31, Danek Duvall wrote:
Shawn Walker wrote:
https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-7145863-1-2/webrev-1-2/
_common.c:
- line 68: "Whever" -> "Wherever"?
- line 192: if (path[0] == '/') ?
Oy, I feel stupid now. And of course it's a little faster...
file.py:
- line 68: Let's not let incorrect usage of "CPython" get into the
source. "CPython" is the interpreter implementation, as distinguished
from Unladen Swallow, Jython, PyPy, etc. If you're talking about
implementing stuff in C, then it's just that: "C". Or "native".
Except that it's not; I called it a CPython function because it uses the
CPython API and is specific to that particular implementation. This C
module wouldn't work with any other implementation of the Python
interpreter.
But if that still seems misleading, I'll change it. s/CPython/external/ ?
...
manifest.py:
- line 863: Whoa. How did that work before? Ditto 912, 913.
I wrote the initial revision of this blind, so yeah, it didn't work. I
had forgotten to test the packagemanager (the sole consumer of this
interface).
It still wasn't quite right before my original changes, but at least it
functioned.
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
