On 04/08/12 13:46, Tim Foster wrote:
On 04/ 9/12 08:41 AM, Danek Duvall wrote:
Tim Foster wrote:
Brock's fix does cause a lint warning - do we care about that here?
(certainly, we've no automated lint-checking in the pkg-gate)
We do care. If (C) lint isn't run automatically as part of the build (I
thought it was, but I don't see how it's tied in), then it should be,
but
that needn't be part of this fix.
timf@kura[524] make zoneproxy-adm
/home/timf/projects/ips/granular-proxies-pkg.hg/src/zoneproxy/zoneproxy-adm
lint -asxm -u -errtags=yes -s -errsecurity=core -Xc99=%none
-D_REENTRANT -I../zoneproxyd zoneproxy-adm.c
"zoneproxy-adm.c", line 109: warning: Function has no return statement
: main (E_FUNC_HAS_NO_RETURN_STMT)
timf@kura[525] echo $?
0
Sure. It gets run, we just don't do anything with the warning that
gets emitted here.
cheers,
tim
Hmm, I did run make lint and just double checked it. On build 13, on my
machine, when I run 'make lint', I get no complaints about
zoneproxy-adm. Maybe I'm using the wrong version of lint or something?
I'll mention that when I run make lint, I see a bunch of other lint
warnings coming from our cpython modules, so that might need adjusting too.
Brock
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
