On 04/17/12 14:02, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7157272-v1
Bug:
7157272 publisher signature properties are not properly propagated
src/modules/client/imageconfig.py:
line 1037: not this changeset, but: s/retuns/returns/
src/modules/p5s.py:
lines 102, 105, 139, 144, 235, 239: nit: None is the default for
get() if no entry exists, so isn't necessary to specify; I realise
some of the other code here does that, so you could either fix
those or just fix the ones added so we're not any worse off
lines 103, 106: on 140, 145, is says "is not None" but here it simply
checks for "is True"; is that intentional?
line 257: why not simply "if not req_names"?
-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
