Hi Tim, Thanks -- that's just what I was hoping to hear. I sent you a webrev link in off-list email. Hopefully I got the packaging changes right. They seem to be working perfectly, so I couldn't have botched it too badly! :-)
Jeff On May 13, 2012, at 5:12 PM, Tim Foster wrote: > On 05/12/12 05:00 AM, Jeff A. Smith wrote: >> I have changes to convert /var/nfs and /var/statmon >> into consumers of the shared /var/share dataset, and >> they work great -- this was much simpler than I expected. > > Great to hear it. Some context for var/share is available below[1]. > >> But, I have a lingering design question. I noticed >> that the current /var/share consumers are packaged >> in system-core-os.mf (mail, cores, crash, audit, etc). >> >> Since the nfs-related dirs I'm converting to be shared >> are packaged in system-file-system-nfs.mf, I added >> the var/share related packaging magic there. > > That should be fine so long as you can guarantee that the migration script is > present, and that it will always run. In this case, as the migration script > is run as part of svc:/system/filesystem/minimal:default and packaged in > core-os, it will. > >> Sorry in advance if this question is too stupid to >> post, but I'd like confirmation that it is okay to do >> the var/share packaging magic in manifests for >> packages that can be removed / uninstalled (unlike >> system-core-os.mf which can't). > > That's a good question. Yes, it's fine to allow non-core-os packages to use > the var/share infrastructure. > > What will happen in the case of a package previously delivering shared > directories, is that once the package delivering /var/.migrate/nfs and the > link /var/nfs -> /var/share/nfs is uninstalled, the previously shared file > and directory content will remain in /var/share, but the system will no > longer contain a /var/nfs symlink. > > [ so booting back to previous BEs that do still have a /var/nfs symlink will > function properly ] > >> Do I need to relocate the var/share changes I added to >> system-file-system-nfs.mf into system-core-os.mf? > > Nope, no need - this was designed to allow multiple packages share their > contents. Hopefully the pkglint checks in ON would have pointed out any > problems wrt. /var/share, but feel free to point me at a webrev offline, and > I'll take a look. > > cheers, > tim > > > [1] The infrastructure for dealing with /var/share and other directories that > need to be shared across boot environments is discussed in the IPS Dev Guide, > Chapter 10 in the section "Delivering Directories To Be Shared Across Boot > Environments", > > http://hub.opensolaris.org/bin/download/Project+pkg/files/ipsdevguide.pdf _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
