On 06/05/12 12:19, Saurabh Vyas wrote:
On 06/ 6/12 12:23 AM, Bart Smaalders wrote:
https://cr.opensolaris.org/action/browse/pkg/barts/spaces-in-filenames/
7174208 pkgsend generate + pkgmogrify don't like spaces in file names
Support spaces and " characters in filenames coming out of pkgsend
generate. Note that this is only an issue between pkgsend generate and
pkgsend publish, so older clients handle this already - the publication
tools just break before this putback if filenames contain either a space
or a double quote.
In general looks good, may be these conditions (combined with multiple
'and') can be put under if all([ cond1, cond2 ...]) ..... may be better
for readability
i.e.
src/modules/actions/generic.py
if "=" not in h and " " not in h and \
'"' not in h:
to
if all (["=" not in h, " " not in h, '"' not in h]):
just as a suggestion....
Whether or not this is more readable is arguable, but it is
significantly slower (about 30% by my quick test), so I'll pass.
- Bart
--
Bart Smaalders Solaris Kernel Performance
[email protected] http://blogs.oracle.com/barts
"You will contribute more with Mercurial than with Thunderbird."
"Civilization advances by extending the number of important
operations which we can perform without thinking about them."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
