Thanks Shawn for your review comments ...... On 06/14/12 03:25 AM, Shawn Walker wrote: ..
src/publish.py: line 367: This must be done *after* pfmri.version.timestr = None. So move this to after line 377.
Done.
lines 370-376: This version check shouldn't be done inside of "allow-timestamp" and it could be simplified.
Done, update the webrev too https://cr.opensolaris.org/action/browse/pkg/saurabhv/CR-7140808-rev1/webrev/
lines 385-389: I don't think this change is necessary; especially if you change things as I suggested above. If it still is, then I'd like to understand the failure case better and it doesn't make sense to me right now.
Taken these changes out (I thought it would be good practice to catch any exception that can raised, but not sure about the failure case for this scenario) Please let me know if these looks good or if anyone have any further comments. Thanks, Saurabh
-Shawn
-- Saurabh Vyas Solaris Install Group, Revenue Product Engineering (RPE), Systems |Bangalore | Green Oracle <http://www.oracle.com/commitment> Oracle is committed to developing practices and products that help protect the environment _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
