Hi Brock,

On 06/15/12 03:04 PM, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7176881-v1

Bugs:
7176881 _RepoStore doesn't pass on changes to read_only
7176886 using cached Repositories breaks multi-publisher publishing

This fix helps Tim land his granular proxy work.

Many thanks for fixing this!  The change looks good to me.

As part of that work,
he made the change on line 2788 of transport.py which had unfortunate
fallout.

That's not exactly the case - in the granular-proxy wad, in publish_cache_contains(..) I'm using a different key to lookup the contents of the pkg.client.transport.repo.RepoCache, but the net result was the same (because that key was always normalized in the same sense that you're normalizing the uri here)

When we were getting a cache hit, and used the Repository object we found there, changes to that object weren't being made all the way down to the FileManager. [ something I thought I'd checked for, but I missed a layer of indirection somewhere along the way, erk ]

        cheers,
                        tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to