On Mon, Jun 18, 2012 at 01:45:44PM -0700, [email protected] wrote: > On Mon, Jun 18, 2012 at 01:15:04PM -0700, Danek Duvall wrote: > > Edward Pilatowicz wrote: > > > > > > > > https://cr.opensolaris.org/action/browse/pkg/edp/pkg.pli.cr3/webrev.cr1.diff > > > > nrlock.py: > > > > - line 58: docstring is identical to the one for locked(); probably could > > have a couple of words added. > > Quick question about this: why is the new method needed? The > implementation of _is_locked is: > > def _is_owned(self): > return self.__owner is current_thread() > > That appears to be functionally identical to the code that's being > added. What am I missing? Also, it's not really safe to call this > function unless you are the lock owner, and want to assert that > condition. I'm assuming that's all you're using this for? >
i was going to use it for that purpose, but then i re-wrote my code to not need locks, so i've just deleted the function. ed _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
