On 06/19/12 10:32, Erik Trauschke wrote:
Hi folks,

please have a quick look at this small change.

7176158 alters the behavior of pkg install -n if no publishers can be
reached. Instead of exit code 4 (nothing to do) it will now exit with 1
(error).
I also added a test case for this fix.

Furthermore I sneaked in a small change to the proxy example (7178155).
The problem is, when you don't specify a trailing slash in your
proxy_base property of the SMF instance and don't specify one in the
ProxyPass rule in apache you will end up with no slash as a separator.
So I made sure our examples are consistent.

webrev is here:

https://cr.opensolaris.org/action/browse/pkg/erisch/7176158/webrev/

src/tests/cli/t_pkg_install.py:
  line 5122: Please name the test after what its testing instead of the
     bug#.  (I've been trying to get rid of that slowly.)

     I'd suggest test_19_refresh_failure

  line 5126: Instead of manipulating the shared test image (which could
    cause failures when tests are run out of order), create a new image
    just for this test:

    self.image_create(self.rurl1, prefix="test1", destroy=True)

    Then you can remove lines 5127 and line 5136.  The rest should still
    work.

-Shawn
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to