On 06/21/12 18:53, Tim Foster wrote:
[snip]
misc.py:
2361+: If I'm reading this right, then if I set 'http_proxy' in my
environment, that's only going to be applied to uri's that are already
being proxied, just with a different proxy. Do I have that right? That
seems sorta busted to me...
Nope, it's only important to override an existing proxy set for a
given origin - otherwise, the default behaviour of libcurl result in
it using the proxy environment variable (as it does in the gate today).
See, I think that's where I'm confused. If I have 2 publishers
configured, one with a proxied origin and one without, and now I do
http_proxy=http://foo.com, I think I'd expect connections for both
publishers, not just the one with a proxied origin, to be routed through
the foo.com proxy. I think that's not how this code works. Is there a
reason I'd only want one of the two publishers to get proxied via
foo.com?
That's not quite it: the get_runtime_proxy method wasn't looking for
environment variables when there wasn't an origin-configured proxy,
but libcurl would still use them internally (since we're not
explicitly telling it which proxy to use), so everything would
continue to get proxied though foo.com in your example.
That said, I still made the change you suggested, because of the
problem I mentioned with stats dump reporting (where even without
origin-configured proxies, we still need to grab the environment
variable in order to print which proxy was used)
Ah. I didn't realize that the libcurl environment lookup happened quite
like that. Thanks for addressing my concerns, nothing left on my end!
Brock
cheers,
tim
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
