Hi Danek,
Agree that only one module is getting fixed with this approach.
I will implement either Shawn's or your suggestion and post the
webrev.
Thanks,
Abhi.
On 06/30/12 17:18, Takeshi Asano wrote:
Hi Danek,
I see your point. Thank you.
Yes, once the gettext.install() call is removed history.py will be
in same state as the other modules. Use of gettext.translation()
can be addressed separately for all modules.
Thanks,
Takeshi
On 2012年06月30日 09:52, Danek Duvall wrote:
Takeshi Asano wrote:
The new code doesn't rely on application's gettext.install() call.
The client/__init__.py does the per-module definition of "_"
and client/history.py imports that.
I realize that the latest proposal does the right thing, but the rest of
the modules don't, and the proposal is to fix just this module. I don't
like the partial solution. Either fix it all, or don't fix this
particular
problem, and get around the fact that history.py i18ns some strings
at the
module level in a different way.
Danek
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
