On 07/20/12 11:56 AM, Edward Pilatowicz wrote:
hey all,
i've got some small and simple bugfixes done:
https://cr.opensolaris.org/action/browse/pkg/edp/pkg.msg/webrev
7182704 None is not an operation
7185026 LinkedImageException doesn't handle empty strings correctly
7185447 pkg remote subcommand needs a private help entry
these are not stoppers (more just nits) so if folks want me to hold off
on them just say so.
api_errors.py:
line 2780: I think here you can leave it like it is. It doesn't look
like there is a string getting passed so there will not be a problem
with empty strings. And if I see this correctly there is a syntactic
difference between 'True' and 'not None', but there is no difference
between 'True' and 'not False'.
Otherwise, lgtm
Erik
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
