On 07/27/12 13:50, Brock Pytlik wrote:
On 07/27/12 10:18, Tim Foster wrote:
Hi Brock,
On 07/24/12 05:44 PM, Brock Pytlik wrote:
Webrev:
https://cr.opensolaris.org/action/browse/pkg/bpytlik/7185843-v1
Just a few nits really:
src/tests/api/t_bootenv.py:
line 52 doesn't need the '+=', '=' would be enough I think
Sure. I prefer the += because that means that if these branches get
reordered, or another inserted above it, this code doesn't need to
change, but unless I hear that that seems reasonable to other people,
I'll change it to '='.
I'm indifferent about this point. The advantage of the current approach
is in case both conditions are somehow true.
-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
