On 07/27/12 15:57, Dan Price wrote:

I introduced a bug in our terminal handling when TERM isn't set or
is set to a bogus value.  Here's a fix:

https://cr.opensolaris.org/action/browse/pkg/dp/setupterm/

If possible I'd like to get this pushed today, so a speedy review
would be much appreciated...

src/modules/client/printengine.py:
  line 118: Downside:
    What is essentially an error is going to be sent to STDOUT
    instead of STDERR.

src/po/POTFILES.in:
  Seems like we should be checking this during the build?
  (Separate bug obviously.)


Assuming we have a test somewhere that ensures the client fallsback to the "basic" progress tracker if we can't use a fancier one, LGTM.

-Shawn
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to