Thanks Danek for review.
On 07/27/12 02:06 PM, Danek Duvall wrote:
Abhinandan Ekande wrote:
https://cr.opensolaris.org/action/browse/pkg/ae112802/7140762-rev3/webrev/
repository.py:
- line 1635: I would keep the "elif e.errno not in ( ... )" construction,
which should have the same effect, but be slightly more compact.
Ok; I will restore earlier "elif e.errno not in" construct.
t_pkgrepo.py:
- line 1364, 1377: use "publish" instead of "pull"
Will change.
- line 1372: We only test both because the OS happens to test for the
EINVAL condition before the EEXIST condition. It could go the other
way around, and then we'd only be testing the EEXIST condition.
If multiple versions exists in repository for a package and if "pkgrepo
remove" is
executed from package directory, then first error always will be EINVAL.
Then next
rmdir will generate EEXIST error. If user removes package from another
directory,
then error will be EEXIST only when multiple versions of package are
present in
repository. So error sequence will be either EINVAL followed by EEXIST,
or only
EEXIST. IMO, in this scenario EEXIST cannot occur before EINVAL.
Is
there value in this sort of combo test? It might make sense to test to
make sure that truck@2 is still there, but that's not going on here.
I will check for truck@2 after removing truck@1.
Abhi.
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
