On Thu 02 Aug 2012 at 04:50PM, Dan Price wrote:
> > printengine.py:
> > 51: I don't think "PrintEngineException" should be in this string,
> > or this shouldn't be an API exception. The expectation of error
> > messages for API exceptions is that they can/will be presented to
> > the user, so including that kind of internal only info doesn't seem
> > appropriate to me.
>
> Ok. I made PrintEngine and Progress exceptions be API exceptions
> I think because someone told me in a previous review that I'd go
> to coding jail if they weren't. Previously these were API exceptions
> that didn't have any messages at all. I personally don't care what
> they are.
>
> > progress.py:
> > 61: Same comment about ProgressTrackerException
> > 2114,2115: Same comment as line 104 in printengine.py
I've made these exceptions subclasses of Exception, not of ApiException
and added a comment about not displaying the 'reason' field to end
users. Does that satisfy the concern?
-dp
--
Daniel Price, Solaris Kernel Engineering
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
