Hi there,

I've a code review here that fixes a problem where zone installs fail if the user has a $http_proxy environment variable set.

The fix makes the 'syspub/0' transport operations special, ensuring that we force an empty proxy value when those (as opposed not setting any proxy, which causes libcurl to look for $http_proxy values)

I've added lots of code comments explaining how this works, though perhaps I went overboard?

https://cr.opensolaris.org/action/browse/pkg/timf/sysrepo-no-envproxy

Along with the test suite changes, I've done manual testing with zone installs both with and without $http_proxy environment variables set, as well as running package operations in the global and non-global zones.

comments welcome,

        cheers,
                        tim

_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to