On 09/12/12 01:02 PM, Bart Smaalders wrote:
On 09/11/12 17:48, Tim Foster wrote:
I've tested a change to src/actions/directory.py that allows us to
perform salvaging when the directory already exists (but the action
install() method is still called, ie. the action has actually changed,
in this case, by adding the 'salvage-from' attribute) but am wondering
if this seems like a sane thing to do?
The man page explicitly states that this happens on directory creation,
which is why I'm being cautious here.
This could work. Could I see the patch or webrev?
Sure, the change just moves a block of code, and while I've done a quick
manual test, I've yet to add unit-tests (so there may yet be snakes in
the grass)
There's a webrev at:
https://cr.opensolaris.org/action/browse/pkg/timf/salvage-to-existing-dir/salvage-to-existing-dir-webrev/
cheers,
tim
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
