On 11/05/12 21:43, Thejaswini wrote:
Folks,
Please review the fixes for the below CR's:
1. 15822242 update-refresh.sh produces noise via cron email
2. 15744194 search -s with a url shouldn't look at other urls
3. 15807844 pkg search for temporary sources fails without configured
publisher
The webrev is @
https://cr.opensolaris.org/action/browse/pkg/tk241774/15744194/webrev/
Thanks,
Thejaswini K.
I've only looked at the search changes.
General comments:
Please wrap lines at 80 characters. It looks to me like several lines
run beyond that limit.
I'm confused by the general approach taken in api.py. There's already a
servers argument coming in that defines what urls/servers should be
examined. That list gets transformed into slist, which is iterated over
when calling transport.do_search. In short, I think the approach taken
here isn't the right one. I think the first step is to determine why
transport.do_search, when -s is given on the command line, is being
called on urls other than that single url.
api.py:
4219: Why is it ok to append a tuple whose repo is None here, but we go
through the trouble of creating a repo at 4224?
t_pkg_search.py:
996-997: This isn't the way to create an image with two origins for the
same publisher. You've created an image with one origin for the
publisher, then overwritten that image with a second image with the
other origin for the publisher.
Brock
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
