On 11/23/12 04:53 PM, Thejaswini wrote:
I have made the necessary changes.
Thanks for that, the changes to add the XML comment look good.
The webrev is @
https://cr.opensolaris.org/action/browse/pkg/tk241774/15744194-rev03/webrev/
Let me know if I can push these changes.
Not yet - you're doing too much work when comparing the output, for example:
961 outfile = os.path.join(self.test_root, "res_temp_pub")
962 self.pkg("search -s %s example_path > %s" %
(self.rurl, outfile))
963 res_list = (open(outfile, "rb")).readlines()
964 self._check(set(res_list), self.res_remote_path)
would be better as:
self.pkg("search -s %s example_path")
actual = self.reduceSpaces(self.output)
self.assertEqualDiff(expected, actual)
Don't bother adding a new self._check(..) method to
TestSearchMultiPublisher, but unless you feel up to it, I also wouldn't
bother replacing the other preexisting uses of self._check() elsewhere
in t_pkg_search. It looks like they were in the codebase before we got
support for assertEqualDiff() so I'd be inclined to leave them there.
New code ought to use assertEqualDiff() though, imho.
cheers,
tim
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
