On 02/01/13 11:25, Edward Pilatowicz wrote:
hey all,

i have a small bugfix (9 lines of actual code) that speeds up noop pkg
operations:

        https://cr.opensolaris.org/action/browse/pkg/edp/pkg.lisyncfast/webrev/
        16269426 noop pkg operations are slow

i benchmarked the fix on my desktop with the following command:

        ptime pkg install --no-refresh -n osnet-incorporation

without the fix execution time was 1 min and 24 sec, with the fix
execution time was 12 seconds.

more details about the analysis/fix are in the bug report.

I was going to point out that self.pd._mediators_change isn't technically finalised until __finalize_mediation() is called, but you seem to have addressed that in the comment.

imageplan.py:
  line 2212: s/there // ?  ('then there' seems wrong)

Otherwise, seems right to me.

-Shawn

_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to