On 02/22/13 10:05 AM, Shawn Walker wrote:
Greetings,

The following webrev adds a '-t' option to pkgdiff for specifying which
action types to compare:

    16383458 pkgdiff should support filtering on action type like pkg
             contents

webrev:
    https://cr.opensolaris.org/action/browse/pkg/swalker/pkg-16383458/webrev/

This seems ok.

Line 115, should you include 'unknown' as well?

Line 142ish - why are we using m.gen_actions() rather than m.gen_actions_by_types(..) just curious - either approach is fine.

        cheers,
                        tim
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to