On 03/19/13 01:51 PM, Tim Foster wrote:
Hi there,
Just a quick reminder that I've got two small fixes out for code review
at the moment, and was wondering if anyone had time to take a look?
The webrevs are:
https://cr.opensolaris.org/action/browse/pkg/timf/sysrepo-resilient-config/sysrepo-resilient-config-webrev/
lgtm
https://cr.opensolaris.org/action/browse/pkg/timf/add-cronjob/add_cronjob-webrev
154: nit: /contains/contain/
you're testing only for the existence of ${CMD} in the whole crontab.
How likely is it that this test might find something the user put in
there (or asked differently, how unique is ${CMD})?
Erik
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
