Sorry for taking so long to review your changes.  They are generally
good, but there are still a few fixes needed:

04_use_su-to-root.patch should not add a test for $DISPLAY as su-to-root
does not require an X display

09-lilo_detection.patch is checking for a grub postinst_hook?!  It
should check for do_bootloader

I should have noticed this earlier, but postinst and prerm are
modifying /etc/kernel-img.conf and this is not allowed (policy ยง10.7.4).
This file belongs to kernel-package which is maintained by Manoj
Srivastava.  You need to discuss with him how to introduce a mechanism
for updating the configuration.  It would probably be best to introduce
a hooks directory that dkms can drop a file in.

Ben.

-- 
Ben Hutchings
Experience is what causes a person to make new mistakes instead of old ones.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Pkg-dkms-maint mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/pkg-dkms-maint

Reply via email to