On Mon, 2009-04-20 at 00:15 +0200, Giuseppe Iuculano wrote: > Hi Ben, > > Finally dkms was accepted :) > > Could you review and upload dkms 2.0.21.1-1 please?
Sorry for the delay; I've reviewed your changes now.
> dkms (2.0.21.1-1) unstable; urgency=low
>
> * [bcda131] Imported Upstream version 2.0.21.1
> * [487ad26] debian/patches/13-template.patch:
> Updated template-dkms-mkdeb Changes:
> - Bump to debhelper 7 compatibility levels
> - Updated to standards version 3.8.0
[...]
It actually claims version 3.8.1 now.
Also I think the postinst addition needs some changes:
> if dpkg --compare-versions "$2" lt-nl "2.0.21.1-1" ; then
To allow for backporting, it might be better to add a "~" on the end of
the version you compare with.
> if [ -e "/etc/modprobe.d/dkms" ]; then
> if [ "`md5sum \"/etc/modprobe.d/dkms\" | sed -e \"s/
> .*//\"`" = \
> "`dpkg-query -W -f='${Conffiles}' dkms | sed -n
> -e \"\\\\' /etc/modprobe.d/dkms's/.* //p\"`" ]
Using backticks here means you have to do a lot of escaping and the
result is really hard to understand. It would be more readable if you
used $() and variables, as in the examples at
<http://wiki.debian.org/DpkgConffileHandling>.
> then
> rm -f "/etc/modprobe.d/dkms"
> fi
> else
> echo "Moving /etc/modprobe.d/dkms to
> /etc/modprobe.d/dkms.conf"
> grep -v '^#' /etc/modprobe.d/dkms >>
> /etc/modprobe.d/dkms.conf
Why remove comments?
> rm -f "/etc/modprobe.d/dkms"
> fi
> fi
Ben.
--
Ben Hutchings
No political challenge can be met by shopping. - George Monbiot
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Pkg-dkms-maint mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/pkg-dkms-maint
