Your message dated Wed, 26 Oct 2016 22:52:02 +0800 with message-id <CAMr=8w64Rwbnh83T-_xU9CYrDTHzUNm=amzg0fpy3pajojg...@mail.gmail.com> and subject line fixed in dkms/2.2.1.0+git20160527-1 has caused the Debian Bug report #684326, regarding DKMS: variable res should be unset just after calling get_module_verinfo() to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 684326: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684326 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: dkms Version: 2.2.0.3-1 Severity: normal Hello, When building a DKMS module that don't supplies MODULE_VERSION strings that tries to replace the in-kernel module that supplies this MODULE_VERSION string DKMS fails to recognize that both modules are different because it is not cleaning the variable res. Just see this dirty test: # Define get_module_verinfo (just c&p from /usr/bin/dmks) $ get_module_verinfo(){ local vals= while read -a vals; do case ${vals[0]} in version:) res[0]=${vals[1]}; res[2]=${vals[2]};; srcversion:) res[1]=${vals[1]};; esac done < <(modinfo $1) } $ unset res $ get_module_verinfo coretemp $ echo $res <- nothing, good since coretemp don't has MODULE_VERSION get_module_verinfo e1000e $ echo $res 1.5.1-k <- GOOD, this is the MODULE_VERSION of e1000e $ get_module_verinfo coretemp $ echo $res 1.5.1-k <- FAIL!! This causes that DKMS don't installs the new module that is clearly different than the in-kernel one (the first has no MODULE_VERSION and the second one has) The attached patch fixes this issue--- a/usr/sbin/dkms 2012-08-08 20:55:42.752487579 +0200 +++ b/usr/sbin/dkms 2012-08-08 20:56:13.451549256 +0200 @@ -646,6 +646,7 @@ # Little helper function for parsing the output of modinfo. get_module_verinfo(){ + unset res local vals= while read -a vals; do case ${vals[0]} in
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---Source-Version: 2.2.1.0+git20160527-1 This is included in upstream release, closing. Regards, Aron
--- End Message ---
_______________________________________________ Pkg-dkms-maint mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-dkms-maint
