On Thu, Mar 19, 2009 at 10:23:45AM -0400, Yaroslav Halchenko wrote: > > On Thu, Mar 19, 2009 at 01:09:51PM +0100, Valentin Haenel wrote: > > > Hi all, > > > > i found a possible typo in setup.py. The file is executable but the > > > she-bang is > > > missing. Maybe i am wrong, but i have attached a patch in case i am not. > > > ;) > > > Not sure whether it should be non-exec or with shebang, since typically > > people do: > > python setup.py install > so, since that is the only usecase for it, ie noone does 'import setup' > and since there is no conditional on __name__, I would actually vote for > shebang. I will accept your patch into yoh/master ;) (I just need to > learn how to do that properly so I could preserve all your commit > information so you come into the history of pymvpa development ;))
Maybe it is worth putting the corresponding reference here: http://www.pymvpa.org/faq.html#i-want-to-develop-a-new-feature-for-pymvpa-how-can-i-do-it-efficiently Doing it like this preserves the information who actually did the patch and does not overwrite it with the ID of the person who just commited it to the repository -- which will eventually lead to an appearance in the PyMVPA changelog movie ;-) http://www.pymvpa.org/history.html Michael -- GPG key: 1024D/3144BE0F Michael Hanke http://apsy.gse.uni-magdeburg.de/hanke ICQ: 48230050 _______________________________________________ Pkg-ExpPsy-PyMVPA mailing list Pkg-ExpPsy-PyMVPA@lists.alioth.debian.org http://lists.alioth.debian.org/mailman/listinfo/pkg-exppsy-pymvpa