Hi Steffen! Here we are, finally, with comments on your patches. I splitted the thread for each single patch, which is something easier to manage.
On Fri, 13 Feb 2009 02:47:31 +0100, Steffen Moeller wrote: >>From b1e4d1b2f0b48a3d9f89d9100e53345a5a328985 Mon Sep 17 00:00:00 2001 > From: Steffen Moeller <[email protected]> > Date: Thu, 12 Feb 2009 23:23:42 +0100 > Subject: [PATCH] Helping the world that blindly follows instructions on > http://wiki.debian.org/DebianOnFreeRunner > with explicit instructions on how to feed back changes. Please let me better explain how at least I prefer patches. Some of the information below should be included in your patch, some others are more general ones and thus they do not belong to install.sh. 1) the patch name should be less than 65 characters and be self-contained, i.e. it should not span multiple lines. I cannot find the official Git reference here, but you can read more at http://git.or.cz/gitwiki/CommitMessageConventions 2) I always prefer to give an idea of which file has changed in the patch name, e.g. how I rephrased the title of this mail. Strictly speaking, I know this is my preference, so no one is obliged to follow it ;-) 3) each patch should have his own mail/thread, because it is easier to spot problems when you deal with single commits. When you have a bundle of patches, you can easily and automatically send them with git-send-email (package git-email in Debian), as explained at http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html 4) patches should always be sent to the pkg-fso-maint mailing list, never to the single authors Given the above, can you reformat your patch, please? Or, IMHO better, another option would be to put all these information into the developer page on the Debian wiki, thus http://wiki.debian.org/Teams/DebianFSO The install.sh file already contains a line that point to the user page on the Debian wiki http://wiki.debian.org/DebianOnFreeRunner The main advantage instead of hardcoding everything into the install.sh file is that everyone can modify/improve the instructions. In any case, you need a working connection if you want to hack on the Git repository. Thx, bye, Gismo / Luca
pgptpHMXkGLps.pgp
Description: PGP signature
_______________________________________________ pkg-fso-maint mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/pkg-fso-maint
