Your message dated Wed, 18 Aug 2021 16:19:39 +0000
with message-id <[email protected]>
and subject line Bug#982665: fixed in golang-github-hashicorp-memberlist 0.2.2-2
has caused the Debian Bug report #982665,
regarding golang-github-hashicorp-memberlist: Please increase the timeout for 
TestMemberlist_SendTo
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
982665: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982665
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: golang-github-hashicorp-memberlist
Version: 0.2.2-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu hirsute ubuntu-patch

Hi,

TestMemberlist_SendTo fails in Ubuntu's autopkgtest infrastructure
because of a timing issue; the messages don't arrive within 3
milliseconds, so we increased the timeout to 12 milliseconds, which
seems to work reliably.

Can you please consider making the same change in Debian?

In Ubuntu, the attached patch was applied to achieve the following:

    - d/p/fix-TestMemberlist_SendTo.patch: due to a timing issue this test fails
      in Ubuntu autopkgtest infrastructure. Wait more time to let messages
      arrive before checking for them.

Thanks for considering the patch.

Logan
diff -Nru 
golang-github-hashicorp-memberlist-0.2.2/debian/patches/fix-TestMemberlist_SendTo.patch
 
golang-github-hashicorp-memberlist-0.2.2/debian/patches/fix-TestMemberlist_SendTo.patch
--- 
golang-github-hashicorp-memberlist-0.2.2/debian/patches/fix-TestMemberlist_SendTo.patch
     1969-12-31 19:00:00.000000000 -0500
+++ 
golang-github-hashicorp-memberlist-0.2.2/debian/patches/fix-TestMemberlist_SendTo.patch
     2020-07-09 10:29:42.000000000 -0400
@@ -0,0 +1,19 @@
+Description: Fix TestMemberlist_SendTo in Ubuntu autopkgtest env
+ For some reason there is a timing issue where it needs to wait more time than
+ in Debian to receive the messages sent. From my tests 12 milliseconds seems
+ enough.
+Author: Lucas Kanashiro <[email protected]>
+Forwarded: not-needed
+Last-Updated: 2020-07-08
+
+--- a/memberlist_test.go
++++ b/memberlist_test.go
+@@ -1062,7 +1062,7 @@
+       }
+ 
+       // Wait for a little while
+-      time.Sleep(3 * time.Millisecond)
++      time.Sleep(12 * time.Millisecond)
+ 
+       msgs1 := d1.getMessages()
+       msgs2 := d2.getMessages()
diff -Nru golang-github-hashicorp-memberlist-0.2.2/debian/patches/series 
golang-github-hashicorp-memberlist-0.2.2/debian/patches/series
--- golang-github-hashicorp-memberlist-0.2.2/debian/patches/series      
2019-10-23 11:17:10.000000000 -0400
+++ golang-github-hashicorp-memberlist-0.2.2/debian/patches/series      
2020-10-06 11:16:25.000000000 -0400
@@ -1,2 +1,3 @@
 01-Vendor-sean--seed.patch
 test--skip_TestShuffleNodes.patch
+fix-TestMemberlist_SendTo.patch

--- End Message ---
--- Begin Message ---
Source: golang-github-hashicorp-memberlist
Source-Version: 0.2.2-2
Done: Dylan Aïssi <[email protected]>

We believe that the bug you reported is fixed in the latest version of
golang-github-hashicorp-memberlist, which is due to be installed in the Debian 
FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dylan Aïssi <[email protected]> (supplier of updated 
golang-github-hashicorp-memberlist package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 18 Aug 2021 17:50:47 +0200
Source: golang-github-hashicorp-memberlist
Architecture: source
Version: 0.2.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team 
<[email protected]>
Changed-By: Dylan Aïssi <[email protected]>
Closes: 941208 982665
Changes:
 golang-github-hashicorp-memberlist (0.2.2-2) unstable; urgency=medium
 .
   * Team upload.
   * Apply patch to fix timing issue in TestMemberlist_SendTo (Closes: #982665)
       Thanks to Lucas Kanashiro
   * Add patch to skip TestMemberList_Ping because it ramdonly fails
       (Closes: #941208)
Checksums-Sha1:
 56075b0a9e438b608104dfa75f76f0a6ab02f4f1 2674 
golang-github-hashicorp-memberlist_0.2.2-2.dsc
 ee18938920c9f37e75e9b5466fc6c32f15f1ceec 11416 
golang-github-hashicorp-memberlist_0.2.2-2.debian.tar.xz
 3ed3d186daa37a67cd4d3c684b496750d878dd3e 10357 
golang-github-hashicorp-memberlist_0.2.2-2_amd64.buildinfo
Checksums-Sha256:
 a30ea3268cc6d9729d716302bf2405a0ea0ccdb917ea85030c796b01054ed882 2674 
golang-github-hashicorp-memberlist_0.2.2-2.dsc
 aff06a860f2799575985a774d6f47e3dff0dbb032c275001323cf15d246785d6 11416 
golang-github-hashicorp-memberlist_0.2.2-2.debian.tar.xz
 4d3efb9c7818ed9ae87c070182828c9a78314f3c81b6e5de7ea536a90a215de0 10357 
golang-github-hashicorp-memberlist_0.2.2-2_amd64.buildinfo
Files:
 c7a81cb0ef5b280f64b7d6154a19f1ef 2674 devel optional 
golang-github-hashicorp-memberlist_0.2.2-2.dsc
 0c69de995bee0bd1532fa0abadd28189 11416 devel optional 
golang-github-hashicorp-memberlist_0.2.2-2.debian.tar.xz
 feceb8eec344ea0df7e99b70c17b2925 10357 devel optional 
golang-github-hashicorp-memberlist_0.2.2-2_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCgAwFiEEmjwHvQbeL0FugTpdYS7xYT4FD1QFAmEdLSUSHGRhaXNzaUBk
ZWJpYW4ub3JnAAoJEGEu8WE+BQ9UEPEP/0PjKUQDqpNj/vYu4nlVMs3WZB8Pu2Ol
en5VXdQxo0MFhOUOHlI1KY41AzFy1XBEO5LhHGvhlops1Rf0wrqILT/m7L/id5be
joUG5v/E8QcHPYbydY1EWaDgoeeAX/Pw4dK290a6Qt0SJHDB2a1P2+9iblzXMi0Q
3PMjViVPxrPX+LsrOczsqz0AUDzxvCO3GAJSua/Ap79jcsJjN77tSm4ApgW0Z+Ie
bBs7SZTSfUGoXwwIRpCeZi7ejPAHBu1JwIBzapdI6K6OO2wFyBJMX6wnT31H0j/N
MPpsyz/8+NpFTyaaXC0OMvJZ7sjt9hNVJFkpAHEpSYXscpWHWM5InCVn2nierK7l
MH8Iz+nW2D1TfR5dx5vs+4UhHDKFmM5UQuGVRilQAzyEFWLfgW8D7kj4yF8F3EVd
+5GlcM/5WyP7it5dSsPbq9fTWWz0d5pELWwHOXV2pbk6Kp+qGWDePiLZQS579gb4
aZXXWHU8y7sG2liuB6DVf4sytpuqdwouO/V1VEDQMByFBrttadm8NlHCLIaSgeMw
/lSlur1JjQtL8hFy4yT0azU92P6YhZq0sYRHESpVgGZOhSYem79zVm3gslZAOBP0
QcDEP5sWBNO0NEc/TQ/4W99Ew+JCpGV+LVLTLok1Xoko4nmUexAZbzTHc5k0sZDa
xjv49e1ntBx/
=G3Vf
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-go-maintainers mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-go-maintainers

Reply via email to