Sorry for the late reply. While the resulting package looks good, I have two comments:
1) In debian/control, you don’t list pkg-go as maintainer. Please make pkg-go the maintainer and yourself an uploader. 2) In debian/copyright, you license the packaging (debian/*) as GPL-2+, whereas upstream is licensed as MPL-2. For simplicity (especially when shipping patches), we typically license packaging the same as upstream. Could you change that please? Note that both of these are things which dh-make-golang automatically does for you. See https://people.debian.org/~stapelberg//2015/07/27/dh-make-golang.html for an introduction if you’re not yet familiar with the tool. On Wed, Sep 9, 2015 at 5:14 AM, Potter, Tim (Cloud Services) <[email protected]> wrote: > [Resend as first try was bounced as spam] > >> On 27 Aug 2015, at 7:42 am, Potter, Tim (Cloud Services) >> <[email protected]> wrote: >> >> n 27 Aug 2015, at 2:26 am, Michael Stapelberg <[email protected]> wrote: >>> >>> Thanks for your work on these packages! >>> >>> On Tue, Aug 25, 2015 at 12:35 PM, Potter, Tim (Cloud Services) >>> <[email protected]> wrote: >>>> Hi everyone. I’ve put together a couple of packages for review. >>>> Hopefully these >>>> are ready to go as they’re quite small. Could someone please review and >>>> upload? >>>> >>>> * golang-github-coreos-go-iptables >>> >>> Uploaded, but I can’t push the tag…? >> >> Thanks Michael! I've fixed up the permissions on this repos - sorry about >> that. >> >> Will let you know when it's safe to upload dhcp4client. > > Hi Michael. The -dhcp4 package has made it to unstable. Could you please > upload the -dhcp4client package? > > > Thanks! > > Tim. -- Best regards, Michael _______________________________________________ Pkg-go-maintainers mailing list [email protected] http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
