Your message dated Fri, 29 Dec 2017 16:48:54 +0000
with message-id <e1euxq2-0003oa...@fasolo.debian.org>
and subject line Bug#885696: fixed in dh-golang 1.27
has caused the Debian Bug report #885696,
regarding dh-golang: Avoid "Use of uninitialized value $args[192] in join or 
string" warnings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
885696: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=885696
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: dh-golang
Version: 1.26
Severity: normal
Tags: patch

Hi,

Due to the chunking algorithm used by dh_golang, we currently print
hundreds of warnings along the lines of:

  Use of uninitialized value $args[192] in join or string at /usr/bin/dh_golang 
line 42.
  Use of uninitialized value $args[193] in join or string at /usr/bin/dh_golang 
line 42.
  Use of uninitialized value $args[194] in join or string at /usr/bin/dh_golang 
line 42.
  […]

This is due to the manual list splicing in exec_chunked which will
return undefined variables.

Patch attached that uses Perl's slice operator instead. It seems to
work on at least golang-github-tjfoc-gmsm.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      la...@debian.org / chris-lamb.co.uk
       `-
diff --git a/script/dh_golang b/script/dh_golang
index 4b577a8..73ded48 100755
--- a/script/dh_golang
+++ b/script/dh_golang
@@ -55,7 +55,7 @@ sub exec_chunked {
 
     my @result;
     for (my $i = 0; $i < @list; $i += CHUNKSIZE) {
-        push @result, exec_single($cmd, @list[$i .. $i + CHUNKSIZE - 1]);
+        push @result, exec_single($cmd, splice(@list, $i, CHUNKSIZE));
     }
 
     return @result;

--- End Message ---
--- Begin Message ---
Source: dh-golang
Source-Version: 1.27

We believe that the bug you reported is fixed in the latest version of
dh-golang, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 885...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dr. Tobias Quathamer <to...@debian.org> (supplier of updated dh-golang package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 29 Dec 2017 17:26:46 +0100
Source: dh-golang
Binary: dh-golang
Architecture: source
Version: 1.27
Distribution: unstable
Urgency: medium
Maintainer: Debian Go Packaging Team 
<pkg-go-maintainers@lists.alioth.debian.org>
Changed-By: Dr. Tobias Quathamer <to...@debian.org>
Description:
 dh-golang  - debhelper add-on for packaging software written in Go (golang)
Closes: 885696
Changes:
 dh-golang (1.27) unstable; urgency=medium
 .
   * Team upload.
   * Remove slash from Vcs-Browser URL
   * Update to Standards-Version 4.1.3, no changes needed
   * Avoid "Use of uninitialized value $args[192] in join or string" warnings.
     Thanks to Chris Lamb <la...@debian.org> (Closes: #885696)
Checksums-Sha1:
 1c3f733f3250cdd8c3ecc078d412e3d9eea8f7ab 1693 dh-golang_1.27.dsc
 c9a4f0ce50e035dcf323f957af65fb8b7bec6354 11288 dh-golang_1.27.tar.xz
 18b34fbf560b430488d06af3f4576b1aefe1e423 5356 dh-golang_1.27_amd64.buildinfo
Checksums-Sha256:
 ad92e5c42cf4a3ff6856f4475e05f98c7cf3970f779c295e555443c618308438 1693 
dh-golang_1.27.dsc
 caec004ff27b304bbf09f8aa410e4d8ac878cf7d20be41978490aff551008087 11288 
dh-golang_1.27.tar.xz
 0d31f5c101e2d7db53555df7a7f44ce361c7013122148183facb2efc825dbc70 5356 
dh-golang_1.27_amd64.buildinfo
Files:
 012515301f619978fe9b5add8e943d53 1693 devel optional dh-golang_1.27.dsc
 24a8fedc5ca63c6efb0e486d9f1b9229 11288 devel optional dh-golang_1.27.tar.xz
 101d16d759c1734fd5d78cbff7d97e4f 5356 devel optional 
dh-golang_1.27_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE0cuPObxd7STF0seMEwLx8Dbr6xkFAlpGbc4ACgkQEwLx8Dbr
6xk+AxAAkrfXsYz4GnXzfCHc+kHVsfAFaPThd02n7lMUH7lhKmK1/T2xkZ9K7PD3
TuOzZs56l+rl7XN+/8hVdZlqac4O2p8MyMgEVONsRalpxVM90zBf5JxoOKy++Zde
nHpprTEcG3X//bzg75aP9kEm23EoF8CxFX3KEXQBL2CmAxDOQn/U1fJiEvG57Pyp
cBwtfmPrEQqPNRHmA9/6ArhT3qUE8Qk9/rRj0RzAuqVwcVGLVROI7rdOSMm2yhX3
lop4zbxdRtEYu3o+9gOe9NvGscDCSYrpR+/7gPxgtLdvUiJPWhppPo4czizU26Nf
Wurljhxw/Pc7aj7v99rA1zv5UVnD8i+gHoIt3SnO5Sspjec9Gf8ivEfznsYcEgjU
zj76bRu6z2+dwi/JRuF8uC9b98/fGlT1y6u3qmXJBXs/m9GjLIOzo7QjhG8GukZw
v4i9U8B6SBAvN7BGU7NIu+GlPTPhJixEkJjoHdKbUtzMNEXeX7eVGcpF+cbkF2tJ
MfICg3w1/uaf0g1A6baglHdwUUdLUUwCNM57bEwhzpm1C3VFzASTntUGrptOglL0
poVsrAjcZ9rHsbhHHwadV+m61qx8H8cp7SICmGR+dQs81orbSjYOfkrr/H9NcnU1
1Qm1HucSLNRs8uEuNqxUUy1bTxn/AHfc/8akPU20tbbuxBpUAQM=
=lcjj
-----END PGP SIGNATURE-----

--- End Message ---
_______________________________________________
Pkg-go-maintainers mailing list
Pkg-go-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers

Reply via email to