Hi Bas, Just moved all patches of libapache2-mod-tile to be handled by gpb pq.
This is modifying a bit the patches you wrote, so I would like to ask you to give it a quick look if the approach is ok, before I push it to the repo. https://salsa.debian.org/xamanu/libapache2-mod-tile/-/commit/3b40acaaa145f944b0597938bd39521f532b102c Thank you, Felix On 8/21/20 11:47 AM, Felix Delattre wrote: > Thanks for the feedback! > > I need to get more familiar with quilt and will submit valid patches next > week. > > Cheers, > Felix > > On 8/21/20 5:19 AM, Sebastiaan Couwenberg wrote: >> On 8/20/20 9:39 PM, Felix Delattre wrote: >>> ===================================== >>> debian/patches/prevent-duplicates.patch >>> ===================================== >>> @@ -0,0 +1,75 @@ >>> +Description: Move variables to prevent duplicates (from >>> https://github.com/openstreetmap/mod_tile/pull/202) >>> +Author: Felix Delattre <[email protected]> >> >> The patch headers look wrong, it seems the changes are from the linked >> PR of which you are not the author. >> >> The following is correct for a patch from a PR: >> >> Description: Move variables to prevent duplicates >> Author: Jon Burgess >> Origin: https://github.com/openstreetmap/mod_tile/pull/202 >> >> See also: https://dep-team.pages.debian.net/deps/dep3/ >>> ===================================== >>> debian/patches/series >>> ===================================== >>> @@ -2,3 +2,5 @@ iniparser.patch >>> openlayers.patch >>> spelling-errors.patch >>> manpage-section-mismatch.patch >>> +prevent-duplicates.patch >>> +update-link-and-typo.patch >> >> The file is update-link-and-path.patch, so this won't apply. >> >> Did you use `quilt new` to create the patch? >> >> That updates the series file automatically. >> >> See also: >> >> https://debian-gis-team.pages.debian.net/policy/policy.html#quilt >> >>> ===================================== >>> debian/patches/spelling-errors.patch >>> ===================================== >> >> The additional fixes are not documented in the patch description. >> >>> ===================================== >>> debian/patches/update-link-and-path.patch >>> ===================================== >>> @@ -0,0 +1,27 @@ >>> +Description: Update links and paths to new locations >>> +Author: Felix Delattre <[email protected]> >> >> Patches should be Forwarded upstream and marked accordingly. >> >> lintian started checking for the recently: >> >> $ lintian-info -t patch-not-forwarded-upstream >> I: patch-not-forwarded-upstream >> N: >> N: According to the DEP-3 headers, this patch has not been forwarded >> N: upstream. Please forward the patch upstream and work with them to >> N: ensure the patch is included in the version control system and in >> N: the next upstream release of your package. >> N: >> N: If this patch should not be forwarded upstream please put >> N: not-needed in the Forwarded header. >> N: >> N: Refer to Debian Developer's Reference section 3.1.4 (Coordination >> N: with upstream developers) and Debian Policy Manual section 4.3 >> N: (Changes to the upstream sources) for details. >> N: >> N: Severity: info >> N: >> N: Check: debian/patches/dep3 >> N: >> >> The openstreetmap-tiles-update-expire changes seem appropriate to >> forward upstream. >> >> Using patches to modify files in the debian directory is not appropriate >> though, those changes should be made directly. >> >> Kind Regards, >> >> Bas >> > > > _______________________________________________ > Pkg-grass-devel mailing list > [email protected] > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-grass-devel > _______________________________________________ Pkg-grass-devel mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-grass-devel
