Your message dated Tue, 8 Aug 2017 16:41:53 +0200
with message-id <20170808144150.qowv6gnenqqve...@mapreri.org>
and subject line Re: Bug#848297: gst-plugins-bad1.0: docstring collision
has caused the Debian Bug report #848297,
regarding gst-plugins-bad1.0: docstring collision
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
848297: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=848297
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: gst-plugins-bad1.0
Version: 1.10.2-1
Severity: minor
Tags: patch upstream
User: reproducible-bui...@lists.alioth.debian.org
Usertags: randomness

Dear Maintainer,

The documentation of GstColorEffectsPreset sometimes uses the docstring
of GstColorEffectsPreset and sometimes the docstring of GstMirrorMode [1]:

│   │   │   ├── 
./usr/share/gtk-doc/html/gst-plugins-bad-plugins-1.0/gst-plugins-bad-plugins-coloreffects.html
│   │   │   │ @@ -188,15 +188,15 @@
│   │   │   │  <div class="refsect2">
│   │   │   │  <a name="GstColorEffectsPreset"></a><h3>enum 
GstColorEffectsPreset</h3>
│   │   │   │ -<p>How to split the video frame and which side reflect</p>
│   │   │   │ +<p>The lookup table to use to convert input colors</p>

I believe that that is caused by the docstring of GstMirrorMode
mistakenly referring to GstColorEffectsPreset:

[[[
diff --git a/gst/geometrictransform/gstmirror.h 
b/gst/geometrictransform/gstmirror.h
index 2084f2c..22e6aa5 100644
--- a/gst/geometrictransform/gstmirror.h
+++ b/gst/geometrictransform/gstmirror.h
@@ -66,7 +66,7 @@ typedef struct _GstMirror GstMirror;
 typedef struct _GstMirrorClass GstMirrorClass;
 
 /**
- * GstColorEffectsPreset:
+ * GstMirrorMode:
  * @GST_MIRROR_MODE_LEFT: Split horizontally and reflect left into right
  * @GST_MIRROR_MODE_RIGHT: Split horizontally and reflect right into left
  * @GST_MIRROR_MODE_TOP: Split horizontally and reflect top into bottom
]]]

Cheers,

Daniel

P.S. Apologies for not making a more thorough investigation; I would,
but for health reasons.

[1] 
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/armhf/gst-plugins-bad1.0.html

--- End Message ---
--- Begin Message ---
Version: 1.10.3-1

On Fri, Dec 16, 2016 at 01:29:02PM +0200, Sebastian Dröge wrote:
> On Fri, 2016-12-16 at 00:44 +0000, Daniel Shahaf wrote:
> > 
> > Dear Maintainer,
> > 
> > The documentation of GstColorEffectsPreset sometimes uses the
> > docstring
> > of GstColorEffectsPreset and sometimes the docstring of GstMirrorMode
> [...]
> 
> Hi Daniel, I've merged your patch upstream and will include it in the
> 1.10.3 release:
> http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=a38887375f3631c9198fa328e76a7ae7b28a16c0
> 
> Thanks for noticing and reporting!

Thank you!


Closing this bug manually since it wasn't closed with the upload.

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature


--- End Message ---
_______________________________________________
pkg-gstreamer-maintainers mailing list
pkg-gstreamer-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-gstreamer-maintainers

Reply via email to