Your message dated Thu, 28 Mar 2013 14:48:27 +0000
with message-id <e1ule7v-0003hg...@franck.debian.org>
and subject line Bug#703382: fixed in maven-debian-helper 1.6
has caused the Debian Bug report #703382,
regarding maven-debian-helper: mh_make: Do not use sudo
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
703382: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703382
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: maven-debian-helper
Version: 1.5.1
Severity: normal
Tags: patch

apt-file has not needed root privileges for its operation since 2008 or
2009 (see #540905 for example), so it's unnecessary to use sudo for its
invokation.

If mh_make finds that the apt-file or devscripts packages are missing,
it ought to give an explanation what to do and exit instead of going
ahead and trying to install packages on behalf of the user. By the way:
If sudo is not installed or if the user has not been sudo privileges,
mh_make would fail in interesting ways...

A patch that removes sudo from the picture is attached below.

Cheers,
-Hilko

commit 438d51ab5e90f2ec8e961785e19f11352542a0a7 (HEAD, refs/heads/master)
Author: Hilko Bengen <ben...@debian.org>
Date:   Tue Mar 19 00:48:48 2013 +0100

    mh_make: Don't use sudo to install extra packages -- bail out using error messages instead.

	Modified   bin/mh_make
diff --git a/bin/mh_make b/bin/mh_make
old mode 100644
new mode 100755
index e8cf157..6b16a9f
--- a/bin/mh_make
+++ b/bin/mh_make
@@ -126,30 +126,27 @@ fi
 
 echo
 echo "Checking that apt-file is installed and has been configured..."
-if [ -f /usr/bin/apt-file ]; then
+if [ ! -x /usr/bin/apt-file ]; then
+    echo "Error: apt-file is not available." >&2
+    echo "Please the 'apt-file' package it and try again." >&2
+    exit 1
+else
     res="ok"
     apt-file search /usr/bin/mvnDebug | grep maven > /dev/null || res="failed"
     if [ $? != 0 ] || [ "$res" == "failed" ]; then
         echo "Warning: apt-file doesn't seem to be configured"
-        echo "Running sudo apt-file update... (this operation may require that you"
-        echo "enter your password)"
-        sudo apt-file update
+        apt-file update
     else
         echo '[ok]'
     fi
-else
-    echo "Warning: apt-file doesn't seem to be installed"
-    echo "Installing apt-file using sudo apt-get install apt-file"
-    sudo apt-get install apt-file
-    sudo apt-file update
 fi
 
 echo
 echo "Checking that licensecheck is installed..."
-if [ ! -f /usr/bin/licensecheck ]; then
-    echo "Warning: licensecheck doesn't seem to be installed"
-    echo "Installing licensecheck using sudo apt-get install devscripts"
-    sudo apt-get install devscripts
+if [ ! -x /usr/bin/licensecheck ]; then
+    echo "Error: licensecheck is not available." >&2
+    echo "Please install the 'devscripts' package and try again." >&2
+    exit 1
 else
     echo '[ok]'
 fi

--- End Message ---
--- Begin Message ---
Source: maven-debian-helper
Source-Version: 1.6

We believe that the bug you reported is fixed in the latest version of
maven-debian-helper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 703...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Koch <tho...@koch.ro> (supplier of updated maven-debian-helper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 28 Mar 2013 11:54:00 +0200
Source: maven-debian-helper
Binary: maven-debian-helper
Architecture: source all
Version: 1.6
Distribution: experimental
Urgency: low
Maintainer: Debian Java Maintainers 
<pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: Thomas Koch <tho...@koch.ro>
Description: 
 maven-debian-helper - Helper tools for building Debian packages with Maven
Closes: 688043 703382
Changes: 
 maven-debian-helper (1.6) experimental; urgency=low
 .
   [Ludovic Claude]
   * d/control:
     - Update Standards-Version to 3.9.2, no changes
   * d/rules: move 'unpatch all POM files' to
     cleanbuilddir target to restore all files to their pristine
     state after building.
   * share/perl/maven.pm: Apply patch to port share/cdbs/1/class/maven.mk to dh.
     Patch made by Steve Langasek <vor...@debian.org>
 .
   [Thomas Koch]
   * Massive code refactorings and cleanup.
 .
   [Hilko Bengen]
   * mh_make: Do not use sudo (Closes: #703382)
 .
   [James Page]
   * Make intelligent decisions about whether to install to /usr/share/java.
     (Closes: #688043) (LP: #1052533)
Checksums-Sha1: 
 883ef74d374fc96c8321e84add7865651849bff7 2050 maven-debian-helper_1.6.dsc
 5634c15a6b422acc4117fe413bb9c94051e66937 164847 maven-debian-helper_1.6.tar.gz
 8f53574521ae41fc98d32d4d343ed939edbe75ac 111434 maven-debian-helper_1.6_all.deb
Checksums-Sha256: 
 b86dfde5b5e3cf1446315ea871bd284adacfd17018e8d408f03178c768313e36 2050 
maven-debian-helper_1.6.dsc
 981c6d85d5955378cb1bda1d78dba406ee7fd0fb5319efb749925b5fab3c164f 164847 
maven-debian-helper_1.6.tar.gz
 484448cf8ff1d8a5f547ec383d4360d68ce866b0d5eb261758d19657da40e5f9 111434 
maven-debian-helper_1.6_all.deb
Files: 
 e5f96e28cefb209287f5e45b2f06019c 2050 java optional maven-debian-helper_1.6.dsc
 7e5963a666472410f5a7ed30d1cb4b9f 164847 java optional 
maven-debian-helper_1.6.tar.gz
 a30f91ce175150386007aaed98c2d031 111434 java optional 
maven-debian-helper_1.6_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJRVD7mAAoJEAf8SJEEK6ZaHFgP+QF4lbz9jT5CKH+7C50I7MBc
Vo7vdUu7rByyLk3qL3t/gk3WaekNbjGP9n8jPxjFc5W7XMzfmACqXrGKIMtDJ512
OUfiHjHeiOg2ZYdZE1+3GAyM5H/zhKnXEV3EkftvAhNbPlcQw9iqxfFm3gDDZibJ
VhczFqI/cSgTP+oyCy8zsj89ufPfn/PExQjR7XuuVqAad+Z7cuCokB0pzYdMck3b
hpDqASxKqGpWue99PHUWZTo26iMnUbiSwCHOFKnZf9W8t8/oKiQtL3mSjQ72uuw5
snZcfXK4FdhCXTcW+aiwk1+znU7KYs6PYVHH0HZaPmnuEkawCUBRztP0HxhV/SEx
ajnAMiVdtU5C9ousYAEoyRYJYNqkuSWjSZSCfVKh+uOQWKgETZ8yidKyE1MLlgiV
1+9F+cPptyREWr+A6vVtXTWQVQRF6AeORcrCTrLrUkn2rnylp5PJOSRq51P1ZjvU
41CL+vWcdkmIjQNJvTdWGZjobkV1GX6GbOfloAz9IvfaL+NXfREVbJnHW/whYM6K
KaSYHeQu6u9dyX4YJcT7yMTVaWjj07zASxjITgN0sk0BKZGeFUNwMvvtMF5wzSnq
blEM9gfaSw+P2fhg8tZxxMXgDrzyi30dsJDzdgfAM9rCqcXN/KMftho6CDJY/4tQ
qtKvMf/rFym/v9EiXcro
=WxBP
-----END PGP SIGNATURE-----

--- End Message ---
__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to