Your message dated Tue, 24 Sep 2013 12:18:29 +0000
with message-id <e1vorzv-0004nn...@franck.debian.org>
and subject line Bug#703376: fixed in javatools 0.44
has caused the Debian Bug report #703376,
regarding javahelper: Remove Maven support from jh_makepkg
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
703376: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=703376
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: javahelper
Version: 0.43
Severity: normal
Tags: patch

jh_makepkg's template for Maven projects produces a debian/rules file
that uses /usr/bin/mvn-debian whose maintainer does not support
"production use". The comment at the top of /usr/bin/mvn-debian is
correct: The template produced by jh_makepkg cannot even determine in a
robust way if the build attempt by mvn-debian has been successful or
not.

Yet, production use is exactly what is implied by templates for building
Debian packages that are output by a script.

In its current form, this template does more harm and frustration than
good for unsuspecting users (DDs such as myself who just want to package
some Maven-built software). On the other hand, supporting Maven seems to
be a bigger, more complicated, task that is better served by mh_make
from the maven-debian-helper package. 

I suggest removing maven "support" from jh_makepkg altogether; see my
patch below.

Cheers,
-Hilko

commit 70ce2c9b74292543625eec6a52bf7d4d1d0af0a9 (HEAD, refs/heads/master)
Author: Hilko Bengen <ben...@debian.org>
Date:   Mon Mar 18 22:58:26 2013 +0100

    Remove Maven support

	Modified   jh_makepkg
diff --git a/jh_makepkg b/jh_makepkg
index c83dfce..32e9eb7 100755
--- a/jh_makepkg
+++ b/jh_makepkg
@@ -1,7 +1,7 @@
 #!/bin/bash --
 
 # options:
-#    make, maven, ant, byhand
+#    make, ant, byhand
 #    app, library
 #    gcj
 
@@ -28,7 +28,6 @@ syntax()
    echo -e "\t-a --app: This is an application package"
    echo -e "\tPick One:"
    echo -e "\t-t --ant: Builds with ant"
-   echo -e "\t-M --maven: Builds with maven2"
    echo -e "\t-k --makefiles: Builds with make"
    echo -e "\t-n --none: Create own buildsystem"
    echo -e "\tPick One:"
@@ -44,7 +43,7 @@ syntax()
    exit 1
 }
 
-ARGS="p package m maintainer e email v upstream l library a app t ant k makefile n none g gcj o openjdk o7 openjdk7 M maven d default" parseargs "$@"
+ARGS="p package m maintainer e email v upstream l library a app t ant k makefile n none g gcj o openjdk o7 openjdk7 d default" parseargs "$@"
 
 BUILDDIR="`pwd`"
 
@@ -170,8 +169,6 @@ esac
 
 if [ -n "`getarg t ant`" ]; then
    BUILD="ant"
-elif [ -n "`getarg M maven`" ]; then
-   BUILD="maven"
 elif [ -n "`getarg k makefiles`" ]; then
    BUILD="make"
 elif [ -n "`getarg n none`" ]; then
@@ -181,7 +178,6 @@ else
    echo "Select:"
    echo -e "\t[A] Ant"
    echo -e "\t[M] Makefiles"
-   echo -e "\t[V] Maven"
    echo -e "\t[N] None---make one for me (Default)"
    echo -n "[Namv] $ "
    read t
@@ -195,10 +191,6 @@ else
          BUILD="make"
          echo "Selected: Makefiles"
          ;;
-      "V"|"v")
-         BUILD="maven"
-         echo "Selected: Maven"
-         ;;
       *)
          BUILD="byhand"
          echo "Selected: No upstream build system"
@@ -211,9 +203,6 @@ case $BUILD in
    "ant")
       DEPENDS="$DEPENDS, ant"
    ;;
-   "maven")
-      DEPENDS="$DEPENDS, maven2, maven-debian-helper"
-   ;;
    "byhand")
    ;;
 esac
@@ -354,15 +343,6 @@ END
       case $BUILD in
          "ant")
          ;;
-         "maven")
-      cat >> debian/rules <<END
-override_dh_auto_build:
-	# Build the package
-	mvn-debian build
-override_dh_auto_clean:
-	mvn-debian clean
-END
-         ;;
          "make")
          ;;
          "byhand")

--- End Message ---
--- Begin Message ---
Source: javatools
Source-Version: 0.44

We believe that the bug you reported is fixed in the latest version of
javatools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 703...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <ni...@thykier.net> (supplier of updated javatools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 24 Sep 2013 14:05:18 +0200
Source: javatools
Binary: jarwrapper javahelper java-propose-classpath
Architecture: source all
Version: 0.44
Distribution: unstable
Urgency: low
Maintainer: Debian Java Maintainers 
<pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: Niels Thykier <ni...@thykier.net>
Description: 
 jarwrapper - Run executable Java .jar files
 java-propose-classpath - Helper script to suggest a classpath for jar files
 javahelper - Helper scripts for packaging Java programs
Closes: 625945 632821 689788 692230 703376 723884
Changes: 
 javatools (0.44) unstable; urgency=low
 .
   * Add a new minor TAP based test suite.
   * Fix bug in jh_repack when removing empty directories.
     Thanks to Francesco Poli for reporting it and writing
     the patch.  (Closes: #689788)
   * Fix the output path for javadoc generated by jh_build.
     Thanks to Jakub Adam for reporting it and writing the
     patch. (Closes: #692230)
   * jh_installeclipse: Allow any installed package to
     provide a .jar dependency, not just those with
     desired-state install.  Thanks to Colin Watson for the
     patch (pulled from Ubuntu's javatools/0.43ubuntu2).
   * ManifestSection.pm: Always write fields in a
     predictable order.  This fixes a FTBFS when the tests
     had a different order.  Thanks to Damyan Ivanov for
     reporting this bug.  (Closes: #723884)
   * jh_depends: Strip leading "file://" before looking for
     a jar file.  Thanks to Rene Engelhard for the bug
     report.  (Closes: #632821)
   * jh_installjavadoc: Apply patch from Markus Koschany to
     insert a default value for the "Author"-field when no
     author is provided.  Also fix a typo in the generated
     doc-base file.  (Closes: #625945)
   * jh_makepkg: Advise people to use mk_make for packges
     with a maven based build system.  Thanks to Hilko
     Bengen for the suggestion.  (Closes: #703376)
   * d/control: Use the canonical URL in the Vcs-* fields.
   * d/control: Bump Standards-Version to 3.9.4 - no
     changes required.
Checksums-Sha1: 
 b2cb0cda4f839dc7854cf689349bcbde2e43c77c 1962 javatools_0.44.dsc
 7f5111bda8927ccc4773983ed5d7c5feee44b112 58773 javatools_0.44.tar.gz
 b28e683c400206f688fd4e57d713da9057957951 15938 jarwrapper_0.44_all.deb
 f0c59315e9cc841d8e1ace37f16ad45a4ce0ea6b 82960 javahelper_0.44_all.deb
 6c8ac12e9bac274871d55311d6d95f5c83545c0d 13016 
java-propose-classpath_0.44_all.deb
Checksums-Sha256: 
 93824812b7a68858cf412835f39d2f39a769a1b5042ecbb5ea8ac298606b3607 1962 
javatools_0.44.dsc
 f4db0f0e6a3a62811b2b423ecc18a98cfa43910c917262f445c48085ba18536e 58773 
javatools_0.44.tar.gz
 df2073ddd2f9b7a806c1be83ab049b79294592af263b5f8adcb35d00b051061e 15938 
jarwrapper_0.44_all.deb
 0259110f7de1043f1bdd10bab43701db79eea47d6c4d10ad4e64c65be24a680b 82960 
javahelper_0.44_all.deb
 b79a5b53cf844e5b4459cebd69667a317ef8ffa6857f22b2e41508c1b2db126f 13016 
java-propose-classpath_0.44_all.deb
Files: 
 54cc22c4b6c35945759e1df6d3679532 1962 java optional javatools_0.44.dsc
 7846ac82357f30ce292cf8faddf5808b 58773 java optional javatools_0.44.tar.gz
 40bcecdaa4ea530be23d675e9ca4fa8e 15938 java optional jarwrapper_0.44_all.deb
 dcea844f7d59b0a8967f755b41872a65 82960 java optional javahelper_0.44_all.deb
 f6c6c3bacbe83f9bd075637e13961770 13016 java optional 
java-propose-classpath_0.44_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQIcBAEBCAAGBQJSQYAoAAoJEAVLu599gGRCWLkQAJAv2Fiiydfwv4JsAs2Geoxc
AFyKaVEo/AOLH/Vj58j2MecE8Ak00gGVCpPyVl0L4vbrrsnd3WUbebI+9v4+S69O
YrTwo60F+w6+CJGS0kuO+1hUC3gGh/2vrSMGMOaTaGAYddX9rMKESyBICyV8cS6D
U0EGlzSKakQ+7hAQ53Js5zd59DLixJuCW1kyV/VRW6JBuCukOS2uf1kn+6WT0Kq9
oVE5nhalY1UG3jUCBQkVnAIxDGY+K98PwFIcrBpb2VBBqdEmp8YqAkV+oouaBTTT
Qg4HHaCssiPSKMth01T7U5RnFjOdgaG6RnkjbWvhQH6YCuS6rtNGn/tDN8/CYLOb
oTqngca6Ap/dfjInh3mA7XpYYyfmQjJd3PZ3NzD+WhZsuxc/3tUi5Q7SC8GL5iMC
YYYZfnENhp22fBFRtb8Bsj8lmeozuFUOHhHTa3MCaGb2uWP2u08sCH0AO2NNaPmK
XPOD5lUDt59XJuXS8cCyC5t5HoT9M9lqRFXsl9te+N7k6DyogvCPWzuyJbOUz3T/
Ta+G84tfNnsEuF4ZQGEvWqYzFKe1nGUmWygHabLt5dun5rU24aEYVJq7KrHaG36g
/iUOijkp7ES3TUi5JxUtxiZmOnTs2v1C0n0rUEG4752zwA65yIOPRNpe/dzlVZm0
+LNf+iJVW/UiKlqRSfV5
=/GZg
-----END PGP SIGNATURE-----

--- End Message ---
__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to