Your message dated Sun, 11 May 2014 15:35:19 +0000
with message-id <e1wjvmz-0000sy...@franck.debian.org>
and subject line Bug#747560: fixed in checkstyle 5.7-2
has caused the Debian Bug report #747560,
regarding Checkstyle unusable with commons-beanutils 1.9.1
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
747560: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=747560
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: checkstyle
Version: 5.7-1

With the release of commons-beanutils 1.9.1 (possibly from commons-beanutils 
1.9.0 itself), the org.apache.commons.collections package was removed from this 
source package, since it was already present in the 
libcommons-collections3-java source package. Because the wrapper script doesn't 
include the latter package in the list of jars to add to the runtime path, 
checkstyle crashes with the following stack trace:

Exception in thread "main" java.lang.NoClassDefFoundError: 
org/apache/commons/collections/FastHashMap
        at 
org.apache.commons.beanutils.PropertyUtilsBean.getPropertyDescriptor(PropertyUtilsBean.java:959)
        at 
org.apache.commons.beanutils.BeanUtilsBean.copyProperty(BeanUtilsBean.java:388)
        at 
com.puppycrawl.tools.checkstyle.api.AutomaticBean.contextualize(AutomaticBean.java:206)
        at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:156)
        at 
com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:184)
        at com.puppycrawl.tools.checkstyle.Main.createChecker(Main.java:143)
        at com.puppycrawl.tools.checkstyle.Main.main(Main.java:120)
Caused by: java.lang.ClassNotFoundException: 
org.apache.commons.collections.FastHashMap
        at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
        at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
        ... 7 more

To fix this, two things need to be done:

1. Edit the wrapper to load the commons-collections3 jar file.
2. Add a dependency on libcommons-collections3-java

In addition, it may be possible to remove the libcommons-beanutils-java 
dependency. A basic test seems to show checkstyle working without the jar file 
loaded at runtime.

I've attached a patch that does the two things above.

See also https://bugs.launchpad.net/ubuntu/+source/checkstyle/+bug/1308794[1]


--
Saikrishna Arcot

--------
[1] https://bugs.launchpad.net/ubuntu/+source/checkstyle/+bug/1308794
=== modified file 'debian/control'
--- debian/control	2013-08-28 18:26:59 +0000
+++ debian/control	2014-04-22 12:05:07 +0000
@@ -9,6 +9,7 @@
                      junit4 (>= 4.8),
                      libantlr-maven-plugin-java,
                      libcommons-beanutils-java (>= 1.5),
+                     libcommons-collections3-java,
                      libcommons-cli-java,
                      libguava-java,
                      libmaven-antrun-plugin-java (>= 1.6),

=== modified file 'debian/wrappers/checkstyle'
--- debian/wrappers/checkstyle	2013-06-17 11:29:36 +0000
+++ debian/wrappers/checkstyle	2014-04-22 12:05:07 +0000
@@ -5,6 +5,6 @@

 find_java_runtime default sunmin5

-find_jars antlr commons-beanutils guava commons-cli commons-logging checkstyle
+find_jars antlr commons-beanutils commons-collections3 guava commons-cli commons-logging checkstyle

 run_java com.puppycrawl.tools.checkstyle.Main "$@"

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
--- Begin Message ---
Source: checkstyle
Source-Version: 5.7-2

We believe that the bug you reported is fixed in the latest version of
checkstyle, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 747...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
tony mancill <tmanc...@debian.org> (supplier of updated checkstyle package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 11 May 2014 08:07:14 -0700
Source: checkstyle
Binary: checkstyle checkstyle-doc
Architecture: source all
Version: 5.7-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Java Maintainers 
<pkg-java-maintainers@lists.alioth.debian.org>
Changed-By: tony mancill <tmanc...@debian.org>
Description: 
 checkstyle - checks Java source against a coding standard
 checkstyle-doc - Documentation for Checkstyle
Closes: 747560
Changes: 
 checkstyle (5.7-2) unstable; urgency=medium
 .
   * Team upload.
   * Patch jar list in wrapper script and add dependency on
     libcommons-colleections3-java.  (Closes: #747560)
     - Thanks to Saikrishna Arcot for the bug report and patch.
   * Update README.Debian
Checksums-Sha1: 
 c5ccfd4520bd3a8ac5d5b9415ec195559c85b157 2412 checkstyle_5.7-2.dsc
 0211e8e951de452f7afec990f22a0b8ae3a67ffb 7952 checkstyle_5.7-2.debian.tar.xz
 337f2e6831893248f30fdc2fa656a50df5e6d275 589652 checkstyle_5.7-2_all.deb
 620220c4e7e4523d87bf2fd28641ec74aa508632 391156 checkstyle-doc_5.7-2_all.deb
Checksums-Sha256: 
 5da78983e2973097d7d29f05fee9701aadc0bd1f063a3a803e5f2ee5c08f0c20 2412 
checkstyle_5.7-2.dsc
 76958fadcfef1a720b8352001f0c9c49ec3a50dc99ddc410ed9f52bbb4bc1afe 7952 
checkstyle_5.7-2.debian.tar.xz
 a08b5e6b04cc6fc7e2ae4f9a9ecc964eb0150198ee7770a274d3d2960446ed90 589652 
checkstyle_5.7-2_all.deb
 f253932721ffe293f79836139bb44e5815e2c2e7ae256bb4ff30787d9c2b950a 391156 
checkstyle-doc_5.7-2_all.deb
Files: 
 9185821cae150a9ac986c3791e15c8c5 589652 java optional checkstyle_5.7-2_all.deb
 8df0516c786e38bfdba80bb36f5c3497 391156 doc optional 
checkstyle-doc_5.7-2_all.deb
 a57405ab3548c8c26382ba041b8a1b17 2412 java optional checkstyle_5.7-2.dsc
 1f0f8d56ea0c5b5c3923048b2fe76a3d 7952 java optional 
checkstyle_5.7-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJTb5XWAAoJECHSBYmXSz6W4D8QALTDWe8u2y6ecxCwiN3vUl2p
frTAdc1U+IUELSGXC5oet38+08Dsk+m986Y9bd5ozDCIG4SS/g0D7mdt1MjkHT8C
h9FF06uqqcWMuN2X1vk3AP3WszhMD83eR21yqMasWIE/4NoWYM+it/jaLogRt7cN
08R/zRTyE7ceRTzGlkhckkSZbRSBFTI9QOQEK7T/ML9ibYRdjWhfjCTkoRZncRoq
VWxkVbRmrpvosZJI5KvdIQe/mAlLV/KJWYn9Py+IV773IxDpzvGDZc//QDOIm2d5
+ouCqviQN51RcEvZMoLZpNGE9EhY3Yx80JvRxdrO8BVFim69hOceT4D4PfReUSw3
2meFIS4LmsLHnirLkl0gJb5d1VXAppjHOqlhyluX62xG0hsTo5iZCk2nNJVHR/Ad
1kmbbXzbOXzaDyBkrMM1O0mgV7IZxktGxO0PwUu/HJNlIuDya8NHwwTPEr/do6xj
EuqYKS+Ft7VPN2dGWuNGqwhNOhH9rnxVq620d9OdylO9v2FW3zhl7vvRkJS9m9w5
lRhoMyxmOxFE/eu1Njf5UY56GIPykPETWGTiwIzojQKVNQIUpcnfepJXb7zq+UEe
67BuVFZCvj4h6J3SM0fA92BwyBxH0ewNS4OztG23/fyeBlLkk3JC8nv6XRnZKin4
lZ0J5q0zMQuKaVPwicuq
=Y1j1
-----END PGP SIGNATURE-----

--- End Message ---
__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to