On Sun, Dec 04, 2016 at 09:07:12PM -0800, tony mancill wrote:
> On Sun, Dec 04, 2016 at 07:47:31PM +0800, 殷啟聰 wrote:
> > FYI, I forwarded the bug to ASM's upstream issue tracker [1].
> > 
> > I propose the follwing patch to fix the bug:
> > 
> >  override_dh_auto_build:
> > -       dh_auto_build -- jar jdoc examples
> > +       dh_auto_build -- -Dproduct.noshrink=true jar jdoc examples
> 
> Looks good to me.  I have applied the patch and will upload this week if
> there are no objections.

Hi,

It's probably too late to object this change since it's about to enter
testing but I suspect this change could trigger FTBFS in libasm-java
reverse dependencies.

I said this because I could verify this specific change prevent
jitescript package [1] to be successfully built with libasm-java
5.2-1. When I built it with 5.1-2 or with a new release on 5.2
reverting only this change, everything works on my side.

As workaround, I ended using libasm4-java as B-D for that package but
this is not ideal.

The error messages I got when I use libasm-java/5.2-1 are:

ERROR] 
/home/miguel/packages/jitescript/jitescript-0.4.1/src/main/java/me/qmx/jitescript/MethodDefinition.java:[58,37]
 incompatible types: java.util.ArrayList<me.qmx.jitescript.VisibleAnnotation> 
cannot be conv
erted to java.util.List<org.objectweb.asm.tree.AnnotationNode>
[ERROR] 
/home/miguel/packages/jitescript/jitescript-0.4.1/src/main/java/me/qmx/jitescript/FieldDefinition.java:[25,35]
 incompatible types: java.util.ArrayList<me.qmx.jitescript.VisibleAnnotation> 
cannot be conve
rted to java.util.List<org.objectweb.asm.tree.AnnotationNode>

You can inspect those files at upstream if interested at [2] and [3].

Cheers,


1. https://ftp-master.debian.org/new/jitescript_0.4.1-1.html
2. 
https://github.com/qmx/jitescript/blob/master/src/main/java/me/qmx/jitescript/MethodDefinition.java#L58
3. 
https://github.com/qmx/jitescript/blob/master/src/main/java/me/qmx/jitescript/FieldDefinition.java#L25

-- 
Miguel Landaeta, nomadium at debian.org
secure email with PGP 0x6E608B637D8967E9 available at http://miguel.cc/key.
"Faith means not wanting to know what is true." -- Nietzsche

Attachment: signature.asc
Description: Digital signature

__
This is the maintainer address of Debian's Java team
<http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-java-maintainers>. 
Please use
debian-j...@lists.debian.org for discussions and questions.

Reply via email to