Your message dated Wed, 21 Nov 2018 09:20:33 +0000
with message-id <e1gpogt-000ilg...@fasolo.debian.org>
and subject line Bug#911344: fixed in node-mapnik 3.7.2+dfsg-3
has caused the Debian Bug report #911344,
regarding node-mapnik: Patch for nodejs 10 / nan 2.11
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
911344: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911344
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: node-mapnik
Severity: normal
Hi,
node-mapnik 3.7 does not build against nodejs 10.12 / nan 2.11.
Simple patch attached to fix this.
Jérémy
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8),
LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Description: Port new instance call to match latest node/nan versions
this patch is backward compatible with previous node/nan versions.
Author: Jérémy Lal <kapo...@melix.org>
Last-Update: 2018-10-18
Forwarded: not-needed, fixed in master
--- a/src/mapnik_image.cpp
+++ b/src/mapnik_image.cpp
@@ -3220,8 +3220,9 @@
{
Image* im = new Image(closure->im);
v8::Local<v8::Value> ext = Nan::New<v8::External>(im);
- v8::Local<v8::Object> image_obj =
Nan::New(constructor)->GetFunction()->NewInstance(1, &ext);
- v8::Local<v8::Value> argv[2] = { Nan::Null(), image_obj };
+ Nan::MaybeLocal<v8::Object> maybe_local =
Nan::NewInstance(Nan::New(constructor)->GetFunction(), 1, &ext);
+ if (maybe_local.IsEmpty()) Nan::ThrowError("Could not create new Image
instance");
+ v8::Local<v8::Value> argv[2] = { Nan::Null(),
maybe_local.ToLocalChecked() };
Nan::MakeCallback(Nan::GetCurrentContext()->Global(),
Nan::New(closure->cb), 2, argv);
}
closure->cb.Reset();
--- End Message ---
--- Begin Message ---
Source: node-mapnik
Source-Version: 3.7.2+dfsg-3
We believe that the bug you reported is fixed in the latest version of
node-mapnik, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 911...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bas Couwenberg <sebas...@debian.org> (supplier of updated node-mapnik package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Wed, 21 Nov 2018 09:21:49 +0100
Source: node-mapnik
Binary: node-mapnik
Architecture: source amd64
Version: 3.7.2+dfsg-3
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers
<pkg-javascript-de...@lists.alioth.debian.org>
Changed-By: Bas Couwenberg <sebas...@debian.org>
Description:
node-mapnik - bindings to the Mapnik tile rendering library for Node.js
Closes: 911344 913708
Changes:
node-mapnik (3.7.2+dfsg-3) unstable; urgency=medium
.
* Team upload.
* Rebuild with mapnik-vector-tile 1.6.1+dfsg-6.
(closes: #913708)
* Add patch by Jérémy Lal to support nodejs 10 / nan 2.11.
(closes: #911344)
Checksums-Sha1:
330407f61be779b7a430f48f39d9abdf1fb71ac3 2294 node-mapnik_3.7.2+dfsg-3.dsc
09c68993b0c5eaaf48380f9d49c49da0ba250ec6 14240
node-mapnik_3.7.2+dfsg-3.debian.tar.xz
6f5b9c43a56d3041c401f9277fceee9cb8446330 17936
node-mapnik_3.7.2+dfsg-3_amd64.buildinfo
f0a3de0cb2226d752d00bd6636ec5a18ed45fccd 681156
node-mapnik_3.7.2+dfsg-3_amd64.deb
Checksums-Sha256:
8eced3c1e4c78ab04419ecdb516fc8a815c7587a63994e26ea772041f8d70efa 2294
node-mapnik_3.7.2+dfsg-3.dsc
a0e2d47f6a35e2b24df920f7ee99e393e051bb1f0a0beae671da2de92c01109e 14240
node-mapnik_3.7.2+dfsg-3.debian.tar.xz
fc7d51c3022496d50a02cb09f9cbbf80677ef5468d36850f9597caf8a44d017a 17936
node-mapnik_3.7.2+dfsg-3_amd64.buildinfo
6bac67bf3b3b8c995a9d7bd83fbf3ff1d079e4a03fe0cf919807adf83e74028e 681156
node-mapnik_3.7.2+dfsg-3_amd64.deb
Files:
c72e65f40ffef8cbdd33e3b8b42210fe 2294 javascript optional
node-mapnik_3.7.2+dfsg-3.dsc
4d48f31ccc4481f388eef05bef3dac31 14240 javascript optional
node-mapnik_3.7.2+dfsg-3.debian.tar.xz
f9aba5b34fcdafcc45ddd4318e67756c 17936 javascript optional
node-mapnik_3.7.2+dfsg-3_amd64.buildinfo
360867df90e508526fbffb4a1e6ce157 681156 javascript optional
node-mapnik_3.7.2+dfsg-3_amd64.deb
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEgYLeQXBWQI1hRlDRZ1DxCuiNSvEFAlv1HbYACgkQZ1DxCuiN
SvHTEA/+IlC9h15ocpOK/11gaSXiKws3CwrvdraOg7bdYyi/5DOfr2Oh8Mw5ZLyA
d1u1O5cSXbRmNsmes3TFgiidwyUYtBuhD5gVnlzUxSiFZAQdXu/1DpAHvjALyU8H
nfcHHVta8BvbxP+lSr1Nbn6yIaab2B/KU4CTVndL4A9GKzl3INTQPpw5Fh71/msJ
/Xq+7aBfW+h5d8X6D2HLFgjWB1uETy24vlGVt9M2gVQSwASyoFQlb36ag8pXwiZw
zhj2UeZeDHqKEAyVk9kiNH8RcvutlBy5xTnZSlGR2PL9DAQMTspRw1d9uxHtDxup
NVHNUuvcj5x1WL2K1RJ/UwuDokiMGCFmwovTdwn9sOa/fKKPR0SFjxRmTdBCZIyx
2pdkh6AeiTRAwqjUwQmCyG43QTU2rxDE4VdCmtTpKvoi9wz3xbMMUAgbCYneGqNI
kwP/+R8ScwJlvA+P0HNx9HZ6KHQKkZsQzz7Sxim8pV5YqzGy7t4RBEwQN/eRo96L
PQhHeaLs7xJuWmdN7UJGaljT822NbRgB4ENLxfXREewveNF7SPXbyQ0H5T5iA+dK
0uB6BPJT+U8qnK+7msRhYfA45+Hmy0+EUdDuff9hbDZKjJshWeCY8TtmJtywS0GL
J79rCexVyPQ6JXwUX/5dNwtN+Dq0hi//I5AcF/Fx/yGpIGJ0WeU=
=zCzM
-----END PGP SIGNATURE-----
--- End Message ---
--
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel