Your message dated Tue, 19 Feb 2019 21:49:13 +0000 with message-id <[email protected]> and subject line Bug#900010: fixed in browser-request 0.3.3-2 has caused the Debian Bug report #900010, regarding autopkgtest failure due to lack of test dependencies to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 900010: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=900010 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: browser-request Version: 0.3.3-1 Tags: patch autopkgtest was failing on this package because it doesn't include nodejs in the test environment. After adding nodejs, it also complains about a lack of XMLHttpRequest. I've attached a patch which fixes both of these issues. Alternatively, you can see my patch on Salsa: https://salsa.debian.org/zebmccorkle-guest/browser-request/tree/add-test-dependencies -- Zebulon McCorkle Email: [email protected] IRC: - zebmccorkle@Freenode - zebmccorkle@OFTC - zeb@EsperNet - zeb@hackint - zeb@PdgnCo - zeb@EFNet PGP: 803A 0F47 82AD DDEA 46BE 055F F8F9 DB8C 1A54 6398 (Zebulon McCorkle <[email protected]>)From a0fd4f22e7ca0ccb007e619fe3b788ee59acecc7 Mon Sep 17 00:00:00 2001 From: Zebulon McCorkle <[email protected]> Date: Thu, 24 May 2018 10:24:07 -0500 Subject: [PATCH] Add nodejs and node-xmlhttprequest as test dependencies The CI builds were failing because the chroot didn't have nodejs installed, adding nodejs as a test dependency fixes this issue. Since there is one binary package for both libjs and node, I figure the libjs version shouldn't depend on nodejs. Since it's required for testing, I put the nodejs dependency in test/control. Fixing this issue brought up another: the Node environment doesn't have a global XMLHttpRequest, which is required by browser-request. To fix this, I added node-xmlhttprequest as a test dependency and assigned its XMLHttpRequest object to `global.XMLHttpRequest`, which sates browser-request. --- debian/tests/control | 2 +- debian/tests/require | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/tests/control b/debian/tests/control index 84c9455..807e53f 100644 --- a/debian/tests/control +++ b/debian/tests/control @@ -1,2 +1,2 @@ Tests: require -Depends: node-browser-request +Depends: nodejs, node-browser-request, node-xmlhttprequest diff --git a/debian/tests/require b/debian/tests/require index 540172a..deb04e0 100644 --- a/debian/tests/require +++ b/debian/tests/require @@ -1,3 +1,3 @@ #!/bin/sh set -e -node -e "require('browser-request');" +node -e "global.XMLHttpRequest = require('xmlhttprequest').XMLHttpRequest; require('browser-request');" -- 2.17.0
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---Source: browser-request Source-Version: 0.3.3-2 We believe that the bug you reported is fixed in the latest version of browser-request, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Xavier Guimard <[email protected]> (supplier of updated browser-request package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 19 Feb 2019 22:25:24 +0100 Source: browser-request Architecture: source Version: 0.3.3-2 Distribution: unstable Urgency: medium Maintainer: Debian Javascript Maintainers <[email protected]> Changed-By: Xavier Guimard <[email protected]> Closes: 900010 Changes: browser-request (0.3.3-2) unstable; urgency=medium . * Team upload * Bump debhelper compatibility level to 11 * Declare compliance with policy 4.3.0 * Clean debian/rules and debian/watch * Remove autopkgtest files: not a node package (Closes: #900010) * Fix VCS fields * Add upstream/metadata * Add Berne Convention comment Checksums-Sha1: 572b1ff9f6848e87cbf288eaf1286a471c45e29d 2002 browser-request_0.3.3-2.dsc aac630e4a209d1f084849ebcab4a04509116453a 2144 browser-request_0.3.3-2.debian.tar.xz Checksums-Sha256: ec5b1f07d456c2252f8a7c879b5f7c45aeb765694672ccb710ec3be065bf8d0d 2002 browser-request_0.3.3-2.dsc 337033f2459cdff216552261a015786a5cf5bba5a5cb0119756fe1309276b9e5 2144 browser-request_0.3.3-2.debian.tar.xz Files: c03e266e973291c61552975de1d952ee 2002 javascript optional browser-request_0.3.3-2.dsc 21f206acf36c6a2b0e2a51c173a1d199 2144 javascript optional browser-request_0.3.3-2.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAlxsdTcACgkQ9tdMp8mZ 7ulJlBAAjD8kZ0yePSL612/Fo2AvWIctiT0R8x0D6qMe6QH+rUUJaHImJXesk0jr dRZuWhZypfy+sD8+ECeqXLzfSaT8Oemege0ftrMqix4dHqt84VPWqon4TBydaIzE 4+H5FQtf7uidEgTSukq7ZePxZdCQoh2sY/6ZK004wtA90ffvWnO32tct8Vm0yVx3 571nevJF1hIwA8E8lDVgPCXnk+oaT3cVzaQU1CuJM+GwP82SXwqGNOuxZybmgYN8 rjiZm4NfxPUUznknfOkGYaL7EBAhzRFDrTLvphJBtITX26lH4DDL5ZBUPx9oglp6 vJwuOjKCi9V4asfIb6FOZwYnw7r5iO5KnfzMVpYNVMSRqLoG1iLuxOyNg+t3L2wv ug4kfWMvd+31XioNiNaRTSEoJdShSyhCbVt/31372QutlWuv7ndaLcmN543HeXgo iUNR1khADsyY2S1Wl1ILJnbIJ1ovhfafTfGgVTHfj/Z/DTAkicu98r9x5oarmgv/ MYcgZHt3IguXZEiuKFCVpkYEytcLTx2k/PuSIzsOBHZ9IznvAJL3RcUcdOUsX5Ir g264kPFF0edi11MhHC/qzDIVsbLV1jehMzcheJ1eifP26TPd9eK0gznCRX+Lq1h5 3Kq+bjG7S405KDBMDIEjsMQ380n3goWYJNE3Fiv6Efyqes1wPfE= =+Ds/ -----END PGP SIGNATURE-----
--- End Message ---
-- Pkg-javascript-devel mailing list [email protected] https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
