On Sat, Jun 1, 2019 at 12:36 PM, Xavier <[email protected]> wrote:
Hello,

seems good to me. Some things:

Though it does not really work when tried with node-babel, tracking it here #929829

 * node-vinylfs
   - build is not reproductible using
node-vinyl-fs_3.0.3.orig-is-utf8.tar.gz added to experimental. Here
     is the diff:

Can you apply it directly to the repo? I had a hard time with this file.

     --- a/is-utf8/utf8.txt
     +++ b/is-utf8/utf8.txt
     @@ -1,7 +1,7 @@
     -asdfasdaaf^M
-传李晨张馨予因压力大分手 侯佩岑晒夫妻出游照(图集)^M -图集:刘亦菲与干爹陈金飞私照 佟丽娅为金鹰节假唱致歉^M -章子怡默认与撒贝宁恋情:心里有数就行 刘恺威谈婚期态度反复^M -图集:日本巨乳童颜女星泳装写真 隋唐裹床单压轴走秀^M -图集:Hold住姐翘二郎腿 蔡琴默认与富商男友分手^M -图集:港三级片首映女星低胸亮相 李嘉欣自曝无意再造人^M
     +asdfasdaaf
+传李晨张馨予因压力大分手 侯佩岑晒夫妻出游照(图集) +图集:刘亦菲与干爹陈金飞私照 佟丽娅为金鹰节假唱致歉 +章子怡默认与撒贝宁恋情:心里有数就行 刘恺威谈婚期态度反复 +图集:日本巨乳童颜女星泳装写真 隋唐裹床单压轴走秀 +图集:Hold住姐翘二郎腿 蔡琴默认与富商男友分手 +图集:港三级片首映女星低胸亮相 李嘉欣自曝无意再造人
     --- a/lib/file-operations.js
     +++ b/lib/file-operations.js
     @@ -5,7 +5,7 @@
      var fs = require('graceful-fs');
      var assign = require('object.assign');
      var date = require('value-or-function').date;
     -var Writable = require('stream').Writable;
     +var Writable = require('readable-stream').Writable;

      var constants = require('./constants');

 - node-gulp:
   * I added some lintian overrides. There is still a file without
     source (tmatch/coverage/lcov-report/prettify.js) but it seems not
used during build. Perhaps could we remove it from download (Files-
     Excluded) or hide this error?

yes, but there is no easy way to filter it. I have reported a bug.

--
Pkg-javascript-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to