On Sun, Oct 6, 2019 at 22:47, Nicolas Mora <nico...@babelouest.org> wrote:
Hello JS team,

I was able to make a package for i18next here:
<https://salsa.debian.org/babelouest-guest/node-i18next>

Thanks to Pirate's feedback, I now build the bundle with rollup, but the
minified bundle is created with uglifyjs.terser

For some reason, lintian seems to be failing right now, I have the
following error message: "sbuild-build-depends-lintian-dummy : Depends: lintian but it is not going to be installed" but if I run it manually, I
see no errors.

Could a DD check my package and - if it's ok to be pushed in NEW - copy it in the js-team? Or if the package is not ok, tell me what I should do
to improve it?


See https://salsa.debian.org/ruby-team/rails/blob/master/debian/patches/0002-disable-uglify-in-activestorage-rollup-config-js.patch to pass system paths to rollup-plugin-node-resolve instead of copying whole /usr/lib/nodejs.

Pass /usr/lib/nodejs and /usr/share/nodejs both.

Also I think you have applied patches directly in master, we don't follow that scheme in js-team. Please unapply patches from master or otherwise quilt push -a was failing

$ quilt push -a
Applying patch build.patch
patching file .babelrc
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- rejects in file .babelrc
patching file package.json
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- rejects in file package.json
patching file rollup.config.js
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 17.
2 out of 2 hunks FAILED -- rejects in file rollup.config.js
Patch build.patch can be reverse-applied


You can use debian/nodejs/build instead of override_dh_auto_build.


-- 
Pkg-javascript-devel mailing list
Pkg-javascript-devel@alioth-lists.debian.net
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel

Reply via email to