Your message dated Sun, 22 Dec 2019 09:34:43 +0000
with message-id <[email protected]>
and subject line Bug#947042: fixed in node-express 4.17.1-2
has caused the Debian Bug report #947042,
regarding node-express isn't compatible with node-path-to-regexp ≥ 6
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
947042: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=947042
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: node-express
Version: 4.17.1-1
Severity: important
Tags: upstream
Forwarded: https://github.com/expressjs/express/issues/4136
Hi,
node-express is not compatible with recent node-path-to-regex. This
affects node-superagent tests and renders part of express unusable.
The fix is simple but then test fail:
==== 8< ====
diff --git a/lib/router/layer.js b/lib/router/layer.js
index 4dc8e86..cc96d56 100644
--- a/lib/router/layer.js
+++ b/lib/router/layer.js
@@ -13,7 +13,7 @@
* @private
*/
-var pathRegexp = require('path-to-regexp');
+const { pathToRegexp } = require('path-to-regexp');
var debug = require('debug')('express:router:layer');
/**
@@ -42,7 +42,7 @@ function Layer(path, options, fn) {
this.name = fn.name || '<anonymous>';
this.params = undefined;
this.path = undefined;
- this.regexp = pathRegexp(path, this.keys = [], opts);
+ this.regexp = pathToRegexp(path, this.keys = [], opts);
// set fast path flags
this.regexp.fast_star = path === '*'
==== >8 ====
--- End Message ---
--- Begin Message ---
Source: node-express
Source-Version: 4.17.1-2
We believe that the bug you reported is fixed in the latest version of
node-express, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Xavier Guimard <[email protected]> (supplier of updated node-express package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 22 Dec 2019 10:06:05 +0100
Source: node-express
Architecture: source
Version: 4.17.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers
<[email protected]>
Changed-By: Xavier Guimard <[email protected]>
Closes: 947042
Changes:
node-express (4.17.1-2) unstable; urgency=medium
.
* Team upload
* Require node-serve-static ≥ 1.14.1
* Require node-etag ≥ 1.8.1
* Remove part of test modules: cookies, etag, handlebars, mime,
path-to-regexp, send, superagent, supertest and destroy
* Update other test modules
* Update copyrights
* Add patch to be able to use recent path-to-regexp (Closes: #947042)
* Add build dependency to node-cookies and node-supertest
* Remove useless lintian overrides
* Temporarily disable some mvc tests
* Declare compliance with policy 4.4.1
* Add "Rules-Requires-Root: no"
Checksums-Sha1:
6d32a93ea70d429980cea5d2ef22efdb6f424747 2811 node-express_4.17.1-2.dsc
106773e0e7986d968e67f8b64c22251d11ace1ed 68004
node-express_4.17.1-2.debian.tar.xz
Checksums-Sha256:
74e9dce53e8e4d50ca38fa2ed7d9026e4af29b7a2417134e5d1a86c15403ea5b 2811
node-express_4.17.1-2.dsc
391244e844ab762aff67972a8300a39a9dfd73073636d249aa4dac3daac597ed 68004
node-express_4.17.1-2.debian.tar.xz
Files:
ef2631c9870790b52629b3fa8589c390 2811 javascript optional
node-express_4.17.1-2.dsc
eda73222197f1c0b9e573ee636631c6e 68004 javascript optional
node-express_4.17.1-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAl3/NE8ACgkQ9tdMp8mZ
7ulRKw//cTiwujizOuLtN4e8PnF3fB11A90h5VuPF4NNyt0G3GlI+2wVXKuxsGzM
CPqzmpR6tHTnuqo3X7bhBkZubVFnMBb+ZRYJ9LhE6L9tv8suqQJz+PPaJrst8KYH
nmZrHfFa6AJNIy0j997QN2JrVTI42VY90kE2+3BmXIV7MxYscZy7aswDjuzd+ZU4
okDh7TuG0wFi28iOQ3ZplgFvsPBZoLWmMpLPdsMj8VPWUgoNM68h2Kn07TuVBQz+
HVHD2ThWtzh/Ndi+jWSUlSM+glZ0OCOjT+R2AqvJC3xp5XOF8jzFcm4UAjoeu+k1
5bhqQbEB41qq6jEWJfaUlO8TkAf2o+Pr72DEfU3dWG/OvdfQ2cDAACyWQgEvVPPQ
ShE5cIKosp1DjNyaG4fpVooNSy58EaMOsFQP5i+nT1okDGHCfIJjLsCWjenDJUVP
TKznu80+c+Rde0hnwlYA+8kk7U0k2Zh9b7knMpmzETefeKmRpzo5uUjNYryv+4vp
tV4asoBfuToaRwHNlBQAJZHdWX4KyR5wv+3BNbZZqWnO1up222K3tPKqsj4g5Rqb
h+n/TBrjNFTZWSnnqI0ebDdA7BbGa5jHre8cGHzHhbzV6HuYSYGUEQrF0XSZ9ayU
T1i/tYLHtR172bCVXC0oko1n99B8nePmi26ZIiRHt1wO3SI6pCg=
=IMiD
-----END PGP SIGNATURE-----
--- End Message ---
--
Pkg-javascript-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
