Your message dated Sat, 21 Mar 2020 13:04:39 +0000 with message-id <e1jfdnr-000gxd...@fasolo.debian.org> and subject line Bug#954409: fixed in node-browserify-lite 0.5.1-1 has caused the Debian Bug report #954409, regarding node-browserify-lite: please make the output reproducible to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 954409: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=954409 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: node-browserify-lite Version: 0.5.0-8 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: toolchain randomness X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org Hi, Whilst working on the Reproducible Builds effort [0] we noticed that node-browserify-lite generates non-deterministic output. I tracked this down to JSON.stringify not ordering its result by default, resulting in output varying like the below (after pretty- printing): - "./foo": 2, - "./bar": 1, + "./bar": 1, + "./foo": 2, This was affecting many packages, including libjs-webrtc-adapter and likely many more. A patch (by myself) is attached. It is upstream blessed but a new upstream release is also promised shortly if you want to wait for that too. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-diff --git a/index.js b/index.js index 8a01db3..5f6cd0b 100644 --- a/index.js +++ b/index.js @@ -111,12 +111,13 @@ function renderBundle(options, cb) { "})({"; modules.forEach(function(canonicalSourcePath) { + var thisDepMap = depMap[canonicalSourcePath]; out += aliases[canonicalSourcePath] + ": [function(require,module,exports,global){\n"; if (canonicalSourcePath.match(/\.json$/)) { out += "module.exports = "; } out += sources[canonicalSourcePath]; - out += "\n}, " + JSON.stringify(depMap[canonicalSourcePath]) + "],"; + out += "\n}, " + JSON.stringify(thisDepMap, Object.keys(thisDepMap).sort()) + "],"; }); out += "}, {}, " + aliases[entrySourcePath] + ");\n";
--- End Message ---
--- Begin Message ---Source: node-browserify-lite Source-Version: 0.5.1-1 Done: Xavier Guimard <y...@debian.org> We believe that the bug you reported is fixed in the latest version of node-browserify-lite, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 954...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Xavier Guimard <y...@debian.org> (supplier of updated node-browserify-lite package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Sat, 21 Mar 2020 13:43:59 +0100 Source: node-browserify-lite Architecture: source Version: 0.5.1-1 Distribution: unstable Urgency: medium Maintainer: Debian Javascript Maintainers <pkg-javascript-de...@lists.alioth.debian.org> Changed-By: Xavier Guimard <y...@debian.org> Closes: 954409 Changes: node-browserify-lite (0.5.1-1) unstable; urgency=medium . * Team upload * Declare compliance with policy 4.5.0 * Add "Rules-Requires-Root: no" * Add debian/gbp.conf * Use pkg-js-tools auto test & install * New upstream version 0.5.1 (Closes: #954409) Checksums-Sha1: e98fdb1d66754d94a3fca06fde4bfc5678ec17e7 2217 node-browserify-lite_0.5.1-1.dsc aaf7ecc9acc7617aa985d4cfca8deb31376859c2 4895 node-browserify-lite_0.5.1.orig.tar.gz 8f19fd89822ac2b08e39edabbe7ba69ad9970d5f 4960 node-browserify-lite_0.5.1-1.debian.tar.xz Checksums-Sha256: b8952cba8009632295fd03a5db472d040d03c552b095d6af0281f09282c7d34b 2217 node-browserify-lite_0.5.1-1.dsc 364bd195d39ea91c085f536d59eefd12a54e2440e2ddbdb0b6080c3c4ca3cbbb 4895 node-browserify-lite_0.5.1.orig.tar.gz 2d5ed58bed4bec3caee2b0f6ded83e40d19b0a3664cf82fa230d076651b93ec8 4960 node-browserify-lite_0.5.1-1.debian.tar.xz Files: 3bb7525e48304bfe95e726b0b6e5a6ee 2217 javascript optional node-browserify-lite_0.5.1-1.dsc fc607c5a6d0694fd5d7529b83d299db3 4895 javascript optional node-browserify-lite_0.5.1.orig.tar.gz 346fa96f3f3eefa3ff2052c82bcf3118 4960 javascript optional node-browserify-lite_0.5.1-1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEAN/li4tVV3nRAF7J9tdMp8mZ7ukFAl52DOIACgkQ9tdMp8mZ 7ul0ehAAkmFppgQvWH5v4ig2/Aoz3KckWxI5/fXBPHd4CkvektsN0h1j8BTaRRQY YDlSLZSYUGTWelyC9TF5218YbIHgPwKXNvQmHrpByBdAPNJInLX46apEX/pfJLfA aBVnhy0E/UWvp76XRW6mIWW0WEYTx/UMg5FrsxLYzXkJ9VpNcXxdU48EBdnk73lL bfVZngAVPDT+uZz3ea5Afh+480tk5z0tHtRWqXT2/xt994a6H1E5FnPx1L0MDhH1 w836yneWQQ7B1FMlhVSn/rvK7U3tfTTxZX4EnIhf3PZ0CDzrtAXp79ucH0goeSYW ogYWDgt5E4zzQTrXpDkD59FDDtwTDco34H6Z9DO3CcSQiWq8m17gcohQBkVpNkKl upIuTE05yGuUNe5G4x69mosIQxVdvoKjeFCoer/iEXmfK+TTWiOwyUqNlFsYQcUG 2Y7f2tIfnCT4X73fNc6veetYLN9VL5R72/I/efev352ttGj7SUKKWr3vQiER3vtk ylzF4r0oWYZadiQGl3ecwdTtY9FKlbokNIoHpv+EZSp/CNkMZFQTuLml9Kndv61+ ZYdQ9lD+TSBAM5OCBpbkvVI8yV9RfxNsPZjZ8wdhuF98qZEU7Vb5ymUXvlXQ+Ph+ uxRe0HL98TzW/RSi0O1aZJhAtP8urW5r8Pc1ZKCOd/ZzsYMbHBc= =9wdy -----END PGP SIGNATURE-----
--- End Message ---
-- Pkg-javascript-devel mailing list Pkg-javascript-devel@alioth-lists.debian.net https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
