On 06/12/2021 10:11, Daniel Ring wrote:
On 12/5/2021 2:20 PM, Yadd wrote:
On 05/12/2021 23:07, Yadd wrote:
Hi,
Please drop embedded vendors directory from upload (in
Files-Excluded), at least:
* bootstrap, ckeditor, jquery-ui, lightgallery (already packaged) and
maybe some others, please verify
* minified files of others, even if not used in install
It's better than to have many lines in lintian-overrides and explain
that files aren't used (looking at your patch, you already patch
build to use Debian files).
Maybe this can help:
Files-Excluded: vendors
Files-Includes:
.*\.css$
.*\.less$
Be more strict here^
vendors/jquery-ui/js/jquery-ui-1.10.3.custom.js
vendors/jquery-nanoscroller/jquery.nanoscroller.js
vendors/jquery-wakeup/jquery.wakeup.js
vendors/jquery-letterfx/jquery-letterfx.js
vendors/inputosaurus/inputosaurus.js
vendors/jua/jua.js
vendors/keymaster/keymaster.js
vendors/qr.js/qr.js
...
You miss also to patch one "bootstrap" call in tasks/config.js.
Cheers,
Yadd
I repacked the source to remove the unused vendored components and all
of the minified files, and cleaned up the lintian-overrides. I left in
the other non-minified files from the vendored libraries for now; let me
know if you'd prefer those to be removed as well.
Unfortunately I can't remove the vendored copies of bootstrap,
jquery-ui, or modernizr as the Debian versions are incompatible:
- Rainloop uses Bootstrap 2 (very old), Debian has packages for 3 and 4
Bad news...
- Rainloop uses jquery-ui 1.10, Debian has 1.13 (much newer)
It is probably possible to patch rainloop to use 1.13
- Rainloop uses modernizr 3.3, Debian has 2.6 (much older)
The good way here is to update modernizr
Sadly upstream closed my PRs to de-vendor the dependencies without
comment, so there's not much hope of these changing.
Sincerely,
Daniel Ring
--
Pkg-javascript-devel mailing list
[email protected]
https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-javascript-devel
